-
-
Notifications
You must be signed in to change notification settings - Fork 910
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
sources: add property mappings for all oauth and saml sources #8771
Conversation
Signed-off-by: Marc 'risson' Schmitt <marc.schmitt@risson.space>
Signed-off-by: Marc 'risson' Schmitt <marc.schmitt@risson.space>
Signed-off-by: Marc 'risson' Schmitt <marc.schmitt@risson.space>
Signed-off-by: Marc 'risson' Schmitt <marc.schmitt@risson.space>
✅ Deploy Preview for authentik-docs ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
Signed-off-by: Marc 'risson' Schmitt <marc.schmitt@risson.space>
Signed-off-by: Marc 'risson' Schmitt <marc.schmitt@risson.space>
Signed-off-by: Marc 'risson' Schmitt <marc.schmitt@risson.space>
Signed-off-by: Marc 'risson' Schmitt <marc.schmitt@risson.space>
Signed-off-by: Marc 'risson' Schmitt <marc.schmitt@risson.space>
Signed-off-by: Marc 'risson' Schmitt <marc.schmitt@risson.space>
Signed-off-by: Marc 'risson' Schmitt <marc.schmitt@risson.space>
Signed-off-by: Marc 'risson' Schmitt <marc.schmitt@risson.space>
Signed-off-by: Marc 'risson' Schmitt <marc.schmitt@risson.space>
Signed-off-by: Marc 'risson' Schmitt <marc.schmitt@risson.space>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Overall, this is acceptable with the current dev standards. I'm trying to up those standards, however, and left two notes. Just sayin; if you don't make these changes, they're going onto my "cleanup and dedupe" chores list, and it'd be nice to get these done now.
} | ||
} | ||
|
||
renderForm(): TemplateResult { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm trying to discourage return types on methods like these; Lit3 changes the return type of the overall ShadowDOM object, and while this isn't a breaking change, there are others that could be a problem. Lit prefers the symbol nothing
as a schedule-aware placeholder (please don't use html''
(imagine those are backticks; hard to render when they're sigils) to indicate "render nothing"), but nothing
isn't a TemplateResult
and this won't pass a lint check.
In general, TypeScript's "infer return type" algorithm is very good, and I encourage us to start trusting it.
} | ||
|
||
renderForm(): TemplateResult { | ||
return html` <ak-form-element-horizontal label=${msg("Name")} ?required=${true} name="name"> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It looks to me like you have at least one major method (the renderForm()
method) where it and a lot of the imports that support it could be pushed into a parent class. I don't know if you want to address any of the others, but that renderForm()
(35 lines) one is blatant.
Clones found (typescript):
-
PropertyMappingSCIMForm.ts [1:1 - 13:12] (12 lines, 126 tokens)
PropertyMappingScopeForm.ts [1:1 - 13:13] -
PropertyMappingSCIMForm.ts [46:23 - 66:2] (20 lines, 55 tokens)
PropertyMappingScopeForm.ts [73:23 - 93:2] -
PropertyMappingSAMLSourceForm.ts [1:1 - 13:26] (12 lines, 126 tokens)
PropertyMappingScopeForm.ts [1:1 - 13:13] -
PropertyMappingSAMLSourceForm.ts [31:33 - 66:2] (35 lines, 110 tokens)
PropertyMappingSCIMForm.ts [31:19 - 93:2] -
PropertyMappingSAMLForm.ts [1:1 - 13:20] (12 lines, 126 tokens)
PropertyMappingScopeForm.ts [1:1 - 13:13] -
PropertyMappingSAMLForm.ts [69:70 - 93:2] (24 lines, 58 tokens)
PropertyMappingScopeForm.ts [69:21 - 93:2] -
PropertyMappingPlexSourceForm.ts [1:1 - 66:2] (65 lines, 408 tokens)
PropertyMappingScopeForm.ts [1:1 - 93:2] -
PropertyMappingOAuthSourceForm.ts [1:1 - 13:27] (12 lines, 123 tokens)
PropertyMappingScopeForm.ts [1:1 - 13:20] -
PropertyMappingOAuthSourceForm.ts [31:34 - 66:2] (35 lines, 110 tokens)
PropertyMappingSCIMForm.ts [31:19 - 93:2] -
PropertyMappingNotification.ts [37:34 - 72:2] (35 lines, 110 tokens)
PropertyMappingSCIMForm.ts [31:19 - 93:2] -
PropertyMappingLDAPSourceForm.ts [1:1 - 13:26] (12 lines, 123 tokens)
PropertyMappingScopeForm.ts [1:1 - 13:20] -
PropertyMappingLDAPSourceForm.ts [31:33 - 66:2] (35 lines, 110 tokens)
PropertyMappingSCIMForm.ts [31:19 - 93:2]
Signed-off-by: Marc 'risson' Schmitt <marc.schmitt@risson.space>
Signed-off-by: Marc 'risson' Schmitt <marc.schmitt@risson.space>
Signed-off-by: Marc 'risson' Schmitt <marc.schmitt@risson.space>
Signed-off-by: Marc 'risson' Schmitt <marc.schmitt@risson.space>
Signed-off-by: Marc 'risson' Schmitt <marc.schmitt@risson.space>
Signed-off-by: Marc 'risson' Schmitt <marc.schmitt@risson.space>
Co-authored-by: Jens L. <jens@goauthentik.io> Signed-off-by: Marc 'risson' Schmitt <marc.schmitt@risson.space>
Co-authored-by: Jens L. <jens@goauthentik.io> Signed-off-by: Marc 'risson' Schmitt <marc.schmitt@risson.space>
* main: web/admin: refactor property mappings forms (#10810) web: bump API Client version (#10811) sources/saml: Basic support for EncryptedAssertion element. (#10099) web: bump API Client version (#10809) sources: add property mappings for all oauth and saml sources (#8771) web: bump API Client version (#10808) stages/authenticator: add created, last_updated and last_used metadata (#10636) providers/proxy: avoid erroring on logout with session_id is None (#9119) core: bump google-api-python-client from 2.139.0 to 2.140.0 (#10802) core: bump pyyaml from 6.0.1 to 6.0.2 (#10803) core: bump django from 5.0.7 to 5.0.8 (#10804) core: bump goauthentik.io/api/v3 from 3.2024063.1 to 3.2024063.2 (#10805) web: bump @sentry/browser from 8.23.0 to 8.24.0 in /web in the sentry group across 1 directory (#10806) web: bump the wdio group across 2 directories with 2 updates (#10807)
* main: (25 commits) website/docs: add link from Install docs to Enterprise docs (#10827) website/docs: new upgrade page (#10742) stages/authenticator: actually update last_used (#10813) sources/ldap: Add enabled filter for ldap_password_validate signal (#10823) web: bump API Client version (#10821) sources/plex: add property mappings (#10772) core: bump goauthentik.io/api/v3 from 3.2024063.2 to 3.2024063.5 (#10817) web: bump the wdio group across 2 directories with 4 updates (#10818) web: bump chromedriver from 127.0.1 to 127.0.2 in /tests/wdio (#10819) web: update to ESLint 9 (#10812) website/docs: add source property mappings, rework provider property mappings (#10652) web/admin: refactor property mappings forms (#10810) web: bump API Client version (#10811) sources/saml: Basic support for EncryptedAssertion element. (#10099) web: bump API Client version (#10809) sources: add property mappings for all oauth and saml sources (#8771) web: bump API Client version (#10808) stages/authenticator: add created, last_updated and last_used metadata (#10636) providers/proxy: avoid erroring on logout with session_id is None (#9119) core: bump google-api-python-client from 2.139.0 to 2.140.0 (#10802) ...
Details
Next step of #8750.
Also includes #6427
closes #6184
closes #6622
closes #7713
TODO:
Checklist
ak test authentik/
)make lint-fix
)If an API change has been made
make gen-build
)If changes to the frontend have been made
make web
)Docs at #10652