website/docs: fix email template formatting #9330
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes: django.template.exceptions.TemplateSyntaxError: 'blocktrans' doesn't allow other block tags (seen "trans 'You recently requested to change your password for you authentik account. Use the button below to set a new password.'") inside it Signed-off-by: Zapfmeister <zapfmeister@gmail.com>
✅ Deploy Preview for authentik-docs ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
✅ Deploy Preview for authentik-storybook ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
BeryJu
approved these changes
Apr 18, 2024
BeryJu
changed the title
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #9330 +/- ##
==========================================
- Coverage 92.42% 92.41% -0.01%
==========================================
Files 667 667
Lines 32630 32630
==========================================
- Hits 30158 30156 -2
- Misses 2472 2474 +2
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
kensternberg-authentik
added a commit
that referenced
this pull request
Apr 18, 2024
…rities' into web/bug/locale-priorities * refs/remotes/origin/web/bug/locale-priorities: web: fix locale prioritization scheme core: bump aiohttp from 3.9.2 to 3.9.4 (#9339) stages/prompt: fix username field throwing error with existing user (#9342) root: expose session storage configuration (#9337) website/integrations: fix typo (#9340) root: fix go.mod for codeql checking (#9338) root: make redis settings more consistent (#9335) web/admin: fix error in admin interface due to un-hydrated context (#9336) web: bump API Client version (#9334) stages/authenticator_webauthn: fix attestation value (#9333) website/docs: fix SECRET_KEY length (#9328) website/docs: fix email template formatting (#9330) core, web: update translations (#9323) web: bump @patternfly/elements from 3.0.0 to 3.0.1 in /web (#9324) core: bump celery from 5.3.6 to 5.4.0 (#9325) core: bump goauthentik.io/api/v3 from 3.2024022.12 to 3.2024023.1 (#9327) sources/scim: service account should be internal (#9321) web: bump the storybook group in /web with 8 updates (#9266) sources/scim: cleanup service account when source is deleted (#9319)
kensternberg-authentik
added a commit
that referenced
this pull request
Apr 19, 2024
* main: stages/prompt: fix username field throwing error with existing user (#9342) root: expose session storage configuration (#9337) website/integrations: fix typo (#9340) root: fix go.mod for codeql checking (#9338) root: make redis settings more consistent (#9335) web/admin: fix error in admin interface due to un-hydrated context (#9336) web: bump API Client version (#9334) stages/authenticator_webauthn: fix attestation value (#9333) website/docs: fix SECRET_KEY length (#9328) website/docs: fix email template formatting (#9330) core, web: update translations (#9323) web: bump @patternfly/elements from 3.0.0 to 3.0.1 in /web (#9324) core: bump celery from 5.3.6 to 5.4.0 (#9325) core: bump goauthentik.io/api/v3 from 3.2024022.12 to 3.2024023.1 (#9327) sources/scim: service account should be internal (#9321) web: bump the storybook group in /web with 8 updates (#9266) sources/scim: cleanup service account when source is deleted (#9319)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes:
django.template.exceptions.TemplateSyntaxError: 'blocktrans' doesn't allow other block tags (seen "trans 'You recently requested to change your password for you authentik account. Use the button below to set a new password.'") inside it
Details
Fixes an issue in the documentation, which made the example code fail to run.
The newline caused the template not to work and cause the mentioned error.
Checklist
ak test authentik/)make lint-fix)If an API change has been made
make gen-build)If changes to the frontend have been made
make web)If applicable
make website)