-
Notifications
You must be signed in to change notification settings - Fork 15
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
agent discovery #187
agent discovery #187
Conversation
Co-authored-by: duyndh <duyndh@vng.com.vn>
Codecov Report
❗ Your organization is not using the GitHub App Integration. As a result you may experience degraded service beginning May 15th. Please install the Github App Integration for your organization. Read more. Additional details and impacted files@@ Coverage Diff @@
## v2 #187 +/- ##
=====================================
Coverage ? 44.63%
=====================================
Files ? 23
Lines ? 1752
Branches ? 0
=====================================
Hits ? 782
Misses ? 882
Partials ? 88
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
var _ api.JobDistributionServiceServer = (*Master)(nil) | ||
|
||
func (m *Master) Ping(ctx context.Context, request *api.PingRequest) (*api.PingResponse, error) { | ||
//TODO implement me |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should I add a Github issue to implement it?
I believe we will have unit tests for another merge request so that we can run the test. |
Not in this PR: