Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

agent discovery #187

Merged
merged 8 commits into from
Aug 1, 2023
Merged

agent discovery #187

merged 8 commits into from
Aug 1, 2023

Conversation

nqd
Copy link
Contributor

@nqd nqd commented Jul 31, 2023

  1. create proto contract
  2. implement heartbeat at agent side

Not in this PR:

  • handler at master

@codecov-commenter
Copy link

Codecov Report

❗ No coverage uploaded for pull request base (v2@ee738e3). Click here to learn what that means.
Patch has no changes to coverable lines.

❗ Your organization is not using the GitHub App Integration. As a result you may experience degraded service beginning May 15th. Please install the Github App Integration for your organization. Read more.

Additional details and impacted files
@@          Coverage Diff          @@
##             v2     #187   +/-   ##
=====================================
  Coverage      ?   44.63%           
=====================================
  Files         ?       23           
  Lines         ?     1752           
  Branches      ?        0           
=====================================
  Hits          ?      782           
  Misses        ?      882           
  Partials      ?       88           
Flag Coverage Δ
unittests 44.63% <0.00%> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@nguyencatpham nguyencatpham changed the title gent discovery agent discovery Aug 1, 2023
var _ api.JobDistributionServiceServer = (*Master)(nil)

func (m *Master) Ping(ctx context.Context, request *api.PingRequest) (*api.PingResponse, error) {
//TODO implement me
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should I add a Github issue to implement it?

@nguyencatpham
Copy link
Collaborator

nguyencatpham commented Aug 1, 2023

I believe we will have unit tests for another merge request so that we can run the test.

@nqd nqd merged commit 03b8034 into v2 Aug 1, 2023
1 check passed
@nqd nqd deleted the 168-agent-discovery branch August 1, 2023 13:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants