Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add final messages about unsound results #1191

Merged
merged 10 commits into from
Sep 29, 2023
Merged

Add final messages about unsound results #1191

merged 10 commits into from
Sep 29, 2023

Conversation

sim642
Copy link
Member

@sim642 sim642 commented Sep 26, 2023

Closes #1190.

@sim642 sim642 added this to the v2.3.0 milestone Sep 26, 2023
Copy link
Member

@michael-schwarz michael-schwarz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems reasonable, after addressing the new TODOs this introduces to the code, I think we're good to merge this.

@sim642 sim642 merged commit 91ea3b9 into master Sep 29, 2023
16 checks passed
@sim642 sim642 deleted the final-errors branch September 29, 2023 09:12
sim642 added a commit to sim642/opam-repository that referenced this pull request Nov 24, 2023
nberth pushed a commit to nberth/opam-repository that referenced this pull request Jun 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Final errors about unsound results
2 participants