Ignore top level qualifiers in __builtin_types_compatible_p
#157
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
michael-schwarz
approved these changes
Oct 3, 2023
sim642
added a commit
to sim642/opam-repository
that referenced
this pull request
Nov 20, 2023
CHANGES: * Add `asm inline` parsing (goblint/cil#151). * Ignore top level qualifiers in `__builtin_types_compatible_p` (goblint/cil#157). * Add attribute `goblint_cil_nested` to local variables in inner scopes (goblint/cil#155). * Expose `Cil.typeSigAddAttrs`. * Add option to suppress `long double` warnings (goblint/cil#136, goblint/cil#156). * Fix syntactic search (goblint/cil#147).
nberth
pushed a commit
to nberth/opam-repository
that referenced
this pull request
Jun 18, 2024
CHANGES: * Add `asm inline` parsing (goblint/cil#151). * Ignore top level qualifiers in `__builtin_types_compatible_p` (goblint/cil#157). * Add attribute `goblint_cil_nested` to local variables in inner scopes (goblint/cil#155). * Expose `Cil.typeSigAddAttrs`. * Add option to suppress `long double` warnings (goblint/cil#136, goblint/cil#156). * Fix syntactic search (goblint/cil#147).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When trying to analyze the https://github.com/git/git repository, we encountered the following error:
This was due to CIL not understanding that in a construct like
the types are the same.
The built-in function:
int __builtin_types_compatible_p (type1, type2)actually ignores the top level qualifiers (e.g., const, volatile), which was not the case in CIL.This PR adds a test case and fixes the aforementioned issue.