Skip to content
This repository has been archived by the owner on Feb 24, 2024. It is now read-only.

First Attempt at #105 #112

Merged
merged 9 commits into from
Jan 21, 2017
Merged

First Attempt at #105 #112

merged 9 commits into from
Jan 21, 2017

Conversation

paganotoni
Copy link
Member

@paganotoni paganotoni commented Jan 12, 2017

hi @markbates i've implemented the first test scenario for the route appender (#105) to the app.go, it still assumes some things, but wanted to keep you posted and gather some feedback.

@markbates
Copy link
Member

I'll take a look at this after I've had some coffee this morning.

@markbates
Copy link
Member

It would be nice if we could make this a bit more generic. I would like to be able to move this:

https://github.com/gobuffalo/buffalo/blob/master/buffalo/cmd/generate/resource.go#L73

Into app.go as well. Perhaps it takes a string to insert into the file, or function or something. Just spit balling here.

@paganotoni
Copy link
Member Author

@markbates ok just changed it to receive the expression you want to add inside the block, would be great if you provide me a few other examples, for now i'm assuming everything will go inside the if app == null block.

@paganotoni
Copy link
Member Author

@markbates does this last change helps ?

@markbates
Copy link
Member

What is the state of this PR? I'd love to merge it in and use it for the next release.

@paganotoni
Copy link
Member Author

@markbates this one is ready to be used, i also would like to use it for the actions generator.

@markbates markbates merged commit 8d897a9 into master Jan 21, 2017
@markbates markbates deleted the helpers/append-action-helper branch January 21, 2017 17:52
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants