Allow buffalo build to extract assets and put them into a zip file #180

stanislas-m · 2017-01-26T08:46:46Z

This PR implements issue #170.

Signed-off-by: Stanislas Michalak <stanislas.michalak@gmail.com>

stanislas-m · 2017-01-28T08:58:32Z

This PR added a "-e" flag to the build command. This flag extracts assets and put them into a zip file, in the bin directory (next to the executable). The bin directory is also cleaned before build.

The flag also disable the route handling for assets. You can catch "/assets" queries with NGINX, Apache... and serve them from another location (even from CDN, using a redirect).

Further improvements can include a custom function in templates to prefix assets with a custom location, or a default "/assets" path.

markbates · 2017-01-28T09:05:22Z

Thanks. I'll pull this down and play with it when I get to my computer. In the mean time @philipithomas did a great PR yesterday fixing some linting issues. I think there a few things that will need to be fixed in here. Can you please run 'docker build .' to make sure everything is good? Thanks.

stanislas-m · 2017-01-28T09:10:19Z

Sure. The Docker build succeed:

Step 23/23 : RUN buffalo build
 ---> Running in 7650b2612edc
Buffalo version 0.7.1

--> cleaning up target dir
--> running node_modules/.bin/webpack
Hash: 05d30489a12e5b644c7a
Version: webpack 1.14.0
Time: 3051ms
                                 Asset     Size  Chunks             Chunk Names
af7ae505a9eed503f8b8e6982036873e.woff2  77.2 kB          [emitted]  
  f4769f9bdb7466be65088239c12046d1.eot  20.1 kB          [emitted]  
 fa2772327f55d8198301fdb8bcfc8158.woff  23.4 kB          [emitted]  
  e18bbf611f2a2e43afc071aa2f4e1512.ttf  45.4 kB          [emitted]  
  89889688147bd7575d6327160d64e760.svg   109 kB          [emitted]  
  674f50d287a8c48dc19ba404d20fe713.eot   166 kB          [emitted]  
448c34a56d699c29117adc64c43affeb.woff2    18 kB          [emitted]  
 fee66e712a8a08eef5805a46892932ad.woff    98 kB          [emitted]  
  b06871f281fee6b241d60582ae9369b9.ttf   166 kB          [emitted]  
  912ec66d7572ff821749319396470bde.svg   444 kB          [emitted]  
                        application.js   372 kB       0  [emitted]  main
                       application.css   183 kB       0  [emitted]  main
                       images/logo.svg    66 kB          [emitted]  
   [0] multi main 52 bytes {0} [built]
    + 21 hidden modules
Child extract-text-webpack-plugin:
        + 15 hidden modules
--> running go build -v -o bin/hello_world -ldflags -X main.version="2017-01-28T09:20:15Z" -X main.buildTime="2017-01-28T09:20:15Z"
hello_world/a
hello_world/actions
hello_world
--> cleaning up build
----> cleaning up buffalo_build_main.go
----> cleaning up a
----> cleaning up a/a.go
----> cleaning up a/database.go
----> cleaning up buffalo_build_main.go
 ---> b2c8f7408451
Removing intermediate container 7650b2612edc
Successfully built b2c8f7408451

stanislas-m · 2017-01-28T09:37:12Z

And if I add a new RUN command to test the new option:

Step 24/24 : RUN buffalo build -e
 ---> Running in d04df7e438c6
Buffalo version 0.7.1

--> cleaning up target dir
----> cleaning up hello_world
--> running node_modules/.bin/webpack
Hash: 05d30489a12e5b644c7a
Version: webpack 1.14.0
Time: 3029ms
                                 Asset     Size  Chunks             Chunk Names
af7ae505a9eed503f8b8e6982036873e.woff2  77.2 kB          [emitted]  
  f4769f9bdb7466be65088239c12046d1.eot  20.1 kB          [emitted]  
 fa2772327f55d8198301fdb8bcfc8158.woff  23.4 kB          [emitted]  
  e18bbf611f2a2e43afc071aa2f4e1512.ttf  45.4 kB          [emitted]  
  89889688147bd7575d6327160d64e760.svg   109 kB          [emitted]  
  674f50d287a8c48dc19ba404d20fe713.eot   166 kB          [emitted]  
448c34a56d699c29117adc64c43affeb.woff2    18 kB          [emitted]  
 fee66e712a8a08eef5805a46892932ad.woff    98 kB          [emitted]  
  b06871f281fee6b241d60582ae9369b9.ttf   166 kB          [emitted]  
  912ec66d7572ff821749319396470bde.svg   444 kB          [emitted]  
                        application.js   372 kB       0  [emitted]  main
                       application.css   183 kB       0  [emitted]  main
                       images/logo.svg    66 kB          [emitted]  
   [0] multi main 52 bytes {0} [built]
    + 21 hidden modules
Child extract-text-webpack-plugin:
        + 15 hidden modules
--> build assets archive
--> disable self assets handling
--> running go build -v -o bin/hello_world -ldflags -X main.version="2017-01-28T09:33:04Z" -X main.buildTime="2017-01-28T09:33:04Z"
hello_world/a
hello_world/actions
hello_world
--> cleaning up build
----> cleaning up buffalo_build_main.go
----> cleaning up a
----> cleaning up a/a.go
----> cleaning up a/database.go
----> cleaning up buffalo_build_main.go
 ---> b88388ea9c65
Removing intermediate container d04df7e438c6
Successfully built b88388ea9c65

markbates · 2017-01-28T10:09:50Z

Ah yes, that is because #189 hasn't been merged yet. There's still 1 outstanding issue with it. I'm waiting for that to be merged before merging other PRs. I'll pull this down and play with it on the plane.

markbates · 2017-01-28T10:12:32Z

I got an error:

$ buffalo build -e
Buffalo version 0.7.1

--> cleaning up target dir
--> running node_modules/.bin/webpack
Hash: c3e73e81c3f1e1d2d97e
Version: webpack 1.14.0
Time: 3006ms
                                 Asset     Size  Chunks             Chunk Names
         fonts/fontawesome-webfont.ttf   166 kB          [emitted]  
  f4769f9bdb7466be65088239c12046d1.eot  20.1 kB          [emitted]  
 fa2772327f55d8198301fdb8bcfc8158.woff  23.4 kB          [emitted]  
  e18bbf611f2a2e43afc071aa2f4e1512.ttf  45.4 kB          [emitted]  
  89889688147bd7575d6327160d64e760.svg   109 kB          [emitted]  
  674f50d287a8c48dc19ba404d20fe713.eot   166 kB          [emitted]  
af7ae505a9eed503f8b8e6982036873e.woff2  77.2 kB          [emitted]  
 fee66e712a8a08eef5805a46892932ad.woff    98 kB          [emitted]  
  b06871f281fee6b241d60582ae9369b9.ttf   166 kB          [emitted]  
  912ec66d7572ff821749319396470bde.svg   444 kB          [emitted]  
                        application.js   372 kB       0  [emitted]  main
                       application.css   335 kB       0  [emitted]  main
         fonts/fontawesome-webfont.eot   166 kB          [emitted]  
448c34a56d699c29117adc64c43affeb.woff2    18 kB          [emitted]  
        fonts/fontawesome-webfont.woff    98 kB          [emitted]  
         fonts/fontawesome-webfont.svg   444 kB          [emitted]  
       fonts/fontawesome-webfont.woff2  77.2 kB          [emitted]  
                 fonts/FontAwesome.otf   135 kB          [emitted]  
                images/404_example.png   120 kB          [emitted]  
                images/500_example.png   411 kB          [emitted]  
                   images/logo_med.png   157 kB          [emitted]  
                       images/logo.png   366 kB          [emitted]  
                       images/logo.svg    66 kB          [emitted]  
           images/gophertrain_logo.svg  1.22 MB          [emitted]  
                  images/uncle_sam.jpg  20.5 kB          [emitted]  
                       images/repl.gif  6.15 MB          [emitted]  
   [0] multi main 52 bytes {0} [built]
    + 23 hidden modules
Child extract-text-webpack-plugin:
        + 17 hidden modules
--> build assets archive
--> cleaning up build
----> cleaning up buffalo_build_main.go
----> cleaning up a
----> cleaning up a/a.go
----> cleaning up a/database.go
----> cleaning up buffalo_build_main.go
Error: open bin/gobuffalo-assets.zip: no such file or directory

markbates · 2017-01-28T10:13:48Z

It works if I already have a bin directory, which might always be the case.

stanislas-m · 2017-01-28T10:45:52Z

Then we can ensure the bin directory existence. I just looked at the -o option which "set the name of the binary". In fact, this option allows to generate the binary wherever you want: is this option provided to change only the name of the executable? (then, we will have to fix the -o behavior to put the result in the bin dir, with the given name)

If it's not the case, maybe we must put the assets archive in the same location and ensure its existence.

markbates · 2017-01-29T19:33:01Z

@stanislas-m there are some conflicts with main, can you resolve them so i can merge? thanks.

markbates · 2017-01-29T20:20:53Z

Just saw your questions about the -o flag. That's being passed to the go build tool, but this PR should respect that flag and put the assets in wherever that flag points to. That would mean creating that directory, if it doesn't exist.

stanislas-m · 2017-01-29T20:23:26Z

Okay! Then I'm going to fix that.

Place generated assets zip in the output dir.

stanislas-m · 2017-01-29T20:51:40Z

Hum, I forgot something. Please wait for the merge. :)

stanislas-m · 2017-01-29T21:26:31Z

@markbates Seems ok now.

markbates · 2017-02-01T16:45:03Z

Great work on this! Sorry it took so long to get merged!

stanislas-m added 3 commits January 26, 2017 09:43

WIP: Allow buffalo build to extract assets and put them into a zip file.

6579b53

Signed-off-by: Stanislas Michalak <stanislas.michalak@gmail.com>

Disable assets self handling (when using build -e), cleanup old target.

03b16b0

Signed-off-by: Stanislas Michalak <stanislas.michalak@gmail.com>

Go fmt previous commit.

6603005

Merge branch 'master' into 170-allow-assets-split-on-build

82bf9aa

stanislas-m changed the title ~~WIP: Allow buffalo build to extract assets and put them into a zip file~~ Allow buffalo build to extract assets and put them into a zip file Jan 28, 2017

stanislas-m and others added 3 commits January 29, 2017 21:01

Merge branch 'master' into 170-allow-assets-split-on-build

2e92cf0

Go fmt + fix typo.

c7ced07

Fixed lint issue.

5cbe625

stanislas-m and others added 2 commits January 29, 2017 21:47

Create output drectory of not exists.

483b9da

Place generated assets zip in the output dir.

Merge branch 'master' into 170-allow-assets-split-on-build

afb34a7

Fixed target directory handling.

a784cbf

markbates added 3 commits February 1, 2017 10:05

Merge branch 'master' into 170-allow-assets-split-on-build

63e1900

Merge branch 'master' into 170-allow-assets-split-on-build

9f0dade

Merge branch 'master' into 170-allow-assets-split-on-build

07dda33

markbates merged commit 1cf5cf2 into gobuffalo:master Feb 1, 2017

stanislas-m deleted the 170-allow-assets-split-on-build branch February 4, 2017 12:31

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Allow buffalo build to extract assets and put them into a zip file #180

Allow buffalo build to extract assets and put them into a zip file #180

stanislas-m commented Jan 26, 2017 •

edited

Loading

stanislas-m commented Jan 28, 2017 •

edited

Loading

markbates commented Jan 28, 2017

stanislas-m commented Jan 28, 2017 •

edited

Loading

stanislas-m commented Jan 28, 2017

markbates commented Jan 28, 2017

markbates commented Jan 28, 2017 •

edited

Loading

markbates commented Jan 28, 2017

stanislas-m commented Jan 28, 2017

markbates commented Jan 29, 2017

markbates commented Jan 29, 2017

stanislas-m commented Jan 29, 2017

stanislas-m commented Jan 29, 2017

stanislas-m commented Jan 29, 2017 •

edited

Loading

markbates commented Feb 1, 2017

Allow buffalo build to extract assets and put them into a zip file #180

Allow buffalo build to extract assets and put them into a zip file #180

Conversation

stanislas-m commented Jan 26, 2017 • edited Loading

stanislas-m commented Jan 28, 2017 • edited Loading

markbates commented Jan 28, 2017

stanislas-m commented Jan 28, 2017 • edited Loading

stanislas-m commented Jan 28, 2017

markbates commented Jan 28, 2017

markbates commented Jan 28, 2017 • edited Loading

markbates commented Jan 28, 2017

stanislas-m commented Jan 28, 2017

markbates commented Jan 29, 2017

markbates commented Jan 29, 2017

stanislas-m commented Jan 29, 2017

stanislas-m commented Jan 29, 2017

stanislas-m commented Jan 29, 2017 • edited Loading

markbates commented Feb 1, 2017

stanislas-m commented Jan 26, 2017 •

edited

Loading

stanislas-m commented Jan 28, 2017 •

edited

Loading

stanislas-m commented Jan 28, 2017 •

edited

Loading

markbates commented Jan 28, 2017 •

edited

Loading

stanislas-m commented Jan 29, 2017 •

edited

Loading