Skip to content
This repository has been archived by the owner on Feb 24, 2024. It is now read-only.

Fix #181: generate default gitlab ci config #305

Merged
merged 2 commits into from
Mar 23, 2017
Merged

Fix #181: generate default gitlab ci config #305

merged 2 commits into from
Mar 23, 2017

Conversation

stanislas-m
Copy link
Member

Still one question remaining:

My problem is the way the database.yml is generated:

test:
  dialect: postgres
  database: buffalo-test_test
  user: postgres
  password: postgres
  host: 127.0.0.1

Since the PostgreSQL server is not on 127.0.0.1 in this case (it will be on a dynamic host created by Gitlab), the test will fail. So, we can either:

  • ask the user to change the host by hand
  • let Buffalo customize it by tweaking Pop
  • change Pop template to use envOr helper on test case (so we can provide env in the ci script)
  • tweak it at build time, with a bash command like sed or awk

In my opinion, the third option is the best and would not break legacy setups.

@markbates markbates changed the base branch from master to v0.8.0 March 20, 2017 15:14
@markbates
Copy link
Member

"change Pop template to use envOr helper on test case (so we can provide env in the ci script)" 👍

Provide alternate config template for the no-pop support case.
@stanislas-m
Copy link
Member Author

@markbates It should work now. I've added a case without Pop too.

@markbates markbates merged commit 75818ae into gobuffalo:v0.8.0 Mar 23, 2017
@markbates
Copy link
Member

LGTM. :) Thanks!

@stanislas-m stanislas-m deleted the 181-generate-default-gitlab-ci-config branch March 26, 2017 08:58
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants