Resource generator --use-model #297 fixes #328

[as27]

Generates a basic implementation for a resource, which supports crud functionality for a existing model.

[markbates]

I ran buffalo g resource user name email bio:text

it's output:

Buffalo version 0.8.0

--> actions/user.go
--> actions/user_test.go
--> buffalo db g model user name email bio:text
v3.13.3

--> models/user.go
--> models/user_test.go
--> goimports -w .
> migrations/20170327183424_create_users.up.fizz
> migrations/20170327183424_create_users.down.fizz
--> goimports -w .

The UserResource, however, didn't have any of the model stuff in it. It should.

package actions

import "github.com/gobuffalo/buffalo"

type UserResource struct {
	buffalo.Resource
}

// List default implementation.
func (v UserResource) List(c buffalo.Context) error {
	return c.Render(200, r.String("User#List"))
}

// Show default implementation.
func (v UserResource) Show(c buffalo.Context) error {
	return c.Render(200, r.String("User#Show"))
}

// New default implementation.
func (v UserResource) New(c buffalo.Context) error {
	return c.Render(200, r.String("User#New"))
}

// Create default implementation.
func (v UserResource) Create(c buffalo.Context) error {
	return c.Render(200, r.String("User#Create"))
}

// Edit default implementation.
func (v UserResource) Edit(c buffalo.Context) error {
	return c.Render(200, r.String("User#Edit"))
}

// Update default implementation.
func (v UserResource) Update(c buffalo.Context) error {
	return c.Render(200, r.String("User#Update"))
}

// Destroy default implementation.
func (v UserResource) Destroy(c buffalo.Context) error {
	return c.Render(200, r.String("User#Destroy"))
}

[markbates]

This should be plural.

It's generating user := &models.User{}, but it should be users := &models.Users{}

[as27]

I thought that resources are always generated with plural args: buffalo g resource users name email bio:text then the logic works. But I am going to change that.

[as27]

The model stuff is just implemented with the --use-model flag. Because otherwise the tests will fail.

[markbates]

Then the tests need to be fixed. The --use-model flag should be used if you have an existing model, but the default, without any flags, should generate everything.

It's ok in the Dockerfile to delete stuff that was previously generated in the tests, or to create a new app, etc...

[markbates]

This should generate all of the *.html files as well. Each file can contain something basic like:

<h1>Users#List</h1>
Find me at templates/users/list.html

[as27]

• Logic of the flags changed
• added a basic structure for html templates. Later just the files can hold more logic
• changed the generator also to deal with a singular definition.

[markbates]

OMG! This is sooooooooo awesome!! I'm really excited about this! Just started testing it, but so far so good! I can't wait to get this into v0.8.1.

I have a few notes, but nothing big, as far as I can tell.

[markbates]

Have this redirect to the Show action. /users/1234

[markbates]

Have this redirect to the Show action. /users/1234

[markbates]

Add a flash message here to say that it was deleted.

[markbates]

I think this should be a 302.

[markbates]

I think this should be a 302.

[markbates]

I think this should be a 302.

[markbates]

this should be a string containing the name of the model to use.

buffalo g resource users --use-model=user

[markbates]

Some issues with pluralization:

buffalo g resource user name email

--> actions/user.go
--> actions/user_test.go
--> templates/users/_form.html
--> templates/users/edit.html
--> templates/users/index.html
--> templates/users/new.html
--> templates/users/show.html
--> buffalo db g model user name email
v3.13.5

--> models/user.go
--> models/user_test.go
--> goimports -w .
> migrations/20170329204449_create_users.up.fizz
> migrations/20170329204449_create_users.down.fizz
--> goimports -w .

In actions/app.go:

var userResource buffalo.Resource
userResource = UserResource{&buffalo.BaseResource{}}
app.Resource("/user", userResource)

But the resource is named UsersResource.

[markbates]

It looks like the happy path is working great!

$ buffalo g resource users field1 field2 ...
$ buffalo g resource --skip-model users

These still have issues:

$ buffalo g resource user field1 field2 ...
$ buffalo g resource --use-model users

[as27]

• Changed template according to the review
• Minor changes to support different values for resource and model: buffalo g r users --use-model people
• Supports longer camel case names for example: UserComments

[as27]

Basic set of html templates are now generated.
It supports list, show, edit, new and delete out of the box.

[markbates]

#352

I fixed a few bugs and cleaned up some of the HTML.