Skip to content
This repository has been archived by the owner on Feb 24, 2024. It is now read-only.

[feature] implementing some UI for the error and welcome pages #444

Merged
merged 1 commit into from
May 24, 2017

Conversation

paganotoni
Copy link
Member

@paganotoni paganotoni commented May 24, 2017

This PR adds new UI for the welcome and error pages.
cc @markbates

@markbates markbates merged commit a962601 into development May 24, 2017
@markbates markbates deleted the feature-better-welcome branch May 24, 2017 18:34
@markbates
Copy link
Member

Awesome! Thanks Antonio. When reviewing this I noticed that the 404 page wasn't updated. So I removed the old NotFoundHandler and set the default for 404 to be the defaultErrorHandler, which now has the nice new design! 0dd619f

@paganotoni
Copy link
Member Author

Thanks @markbates, oh and i cannot take all the credit, design comes from @nicoleescobar, i just did the html/css changes and the integration, thanks @nicoleescobar!

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants