Skip to content
This repository has been archived by the owner on Feb 24, 2024. It is now read-only.

Add Context.Cookies #569

Merged
merged 5 commits into from
Jul 29, 2017
Merged

Conversation

frederikcreemers
Copy link
Contributor

This gives easy access to request cookies, and makes it easy to set cookies on the response.

Closes #391

This gives easy access to request cookies, and makes it easy to set cookies on the response.

Closes gobuffalo#391
@frederikcreemers frederikcreemers changed the base branch from master to development July 29, 2017 18:38
@markbates
Copy link
Member

This looks great! Should we have a function that let's people set an http.Cookie? I love the helper methods for the common use case, but also being able to set a complex cookie the user defines would be great.

@frederikcreemers
Copy link
Contributor Author

frederikcreemers commented Jul 29, 2017 via email

@markbates
Copy link
Member

@bigblind good point.

@markbates
Copy link
Member

@bigblind It looks like your branch is in some crazy weird state. It has huge conflicts with development and says 25 files have changed and such. Can you figure out what's going on there so I can merge? Thanks.

@frederikcreemers
Copy link
Contributor Author

@markbates, I'm sorry, I messed up a bit. should be fixed now.

@markbates markbates added this to the 0.9.3 milestone Jul 29, 2017
@markbates markbates merged commit 1684e47 into gobuffalo:development Jul 29, 2017
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants