This repository has been archived by the owner on Feb 24, 2024. It is now read-only.
-
-
Notifications
You must be signed in to change notification settings - Fork 577
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This gives easy access to request cookies, and makes it easy to set cookies on the response. Closes gobuffalo#391
This looks great! Should we have a function that let's people set an |
I didn't add this, because I thought these people would just use
http.SetCookie directly. The whole reason for this wrapper to exist, is so
people don't have to manually construct cookies, or even import the http
package. If I were to add this method, it'd simply call http.SetCookie with
the context's responseWriter, and the passed-in cookie. The only advantage
of calling this wrapper rather than the original, is that you don't have to
pass in the response, but I don't think that's a huge benefit.
But ultimately, it's simple to implement, and doesn't add any complexity,
so I can implement it if you want.
…On Sat, Jul 29, 2017 at 9:08 PM Mark Bates ***@***.***> wrote:
This looks great! Should we have a function that let's people set an
http.Cookie? I love the helper methods for the common use case, but also
being able to set a complex cookie the user defines would be great.
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
<#569 (comment)>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/AAtA1eYKrH4yP8x9KMUlgeHo0J4WfIFJks5sS4MXgaJpZM4OnauC>
.
|
@bigblind good point. |
@bigblind It looks like your branch is in some crazy weird state. It has huge conflicts with |
@markbates, I'm sorry, I messed up a bit. should be fixed now. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This gives easy access to request cookies, and makes it easy to set cookies on the response.
Closes #391