This repository has been archived by the owner on Feb 24, 2024. It is now read-only.
Skip the windows directory when looking for plugins #582
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This contains windows internals and isn't a likely place for plugins
|
Looks like code climate is failing. |
|
@markbates The line that Code Climate is failing on, isn't one that I changed. I'll run |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The buffalo command can seemingly hang when looking for plugins on some Windows systems. The
%PATH%could have multiple entries containingC:\windowscausing multiple file walks of the same directories.Filewalking that path is fairly expensive, as it has many files and folders, most of which are Windows internals.
Adding this change dropped the startup time from ~30s to less than a second.