This repository has been archived by the owner on Feb 24, 2024. It is now read-only.
making buffalo call grift for the tasks #98
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
markbates
approved these changes
Jan 7, 2017
|
@apaganobeleno there are a few code climate issues on this PR. should be pretty quick to fix up though. |
|
@markbates yes, i'll take care of those shortly, thanks for reviewing! should i fix similar other as well ? |
[cleaning] fixing issues with codeclimate cleaning error messages now for real
|
You are crushing these issues!! Thank you so much! |
|
@markbates thanks for the chance!. one question, should we look into writing tests for our cmd package, i don't see that in the repo, but would be something guarantees stability in the future. |
|
It would definitely be nice. There are smoke tests in the Dockerfile which run some of them. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@markbates this is related to #59. is this what you would expect ?