Skip to content
This repository has been archived by the owner on Mar 27, 2024. It is now read-only.

Upgrading buffalo app (0.18.1) fails with template error #80

Closed
skoslitz opened this issue Dec 5, 2021 · 4 comments
Closed

Upgrading buffalo app (0.18.1) fails with template error #80

skoslitz opened this issue Dec 5, 2021 · 4 comments
Labels
bug Something isn't working

Comments

@skoslitz
Copy link

skoslitz commented Dec 5, 2021

~~~ Rewriting Imports ~~~
~~~ Checking webpack.config.js ~~~
Usage:
  buffalo fix [flags]

Aliases:
  fix, update

Flags:
  -h, --help   help for fix
  -y, --y      update all without asking for confirmation

ERRO[0007] Error: template: "webpack" is an incomplete or empty template

Previous buffalo version is v0.15.5, actual go version 1.17.3
Buffalo info gives no errors.

@lsorba
Copy link

lsorba commented Dec 9, 2021

Hello, I have the same error from 1.18.0 to 1.18.1 using both buffalo update and buffalo fix

@fasmat
Copy link
Member

fasmat commented Dec 12, 2021

I've identified the cause of the issue and it will be fixed as part of this PR: #75

@paganotoni can you move this issue to the CLI repo?

@fasmat fasmat self-assigned this Dec 12, 2021
@paganotoni paganotoni transferred this issue from gobuffalo/buffalo Dec 13, 2021
rohrschacht added a commit to rohrschacht/cli that referenced this issue Dec 14, 2021
@rohrschacht
Copy link
Contributor

It seems I have identified the issue to be that the name given to template.New() has to be the same name of the file in the embedded FS, although that is also given to ParseFS. It seems I have solved it in 35bf6e7, it does not give me the "incomplete or empty template" error anymore when I try to fix. Shall I open a PR?

@fasmat
Copy link
Member

fasmat commented Dec 14, 2021

It seems I have identified the issue to be that the name given to template.New() has to be the same name of the file in the embedded FS, although that is also given to ParseFS. It seems I have solved it in 35bf6e7, it does not give me the "incomplete or empty template" error anymore when I try to fix. Shall I open a PR?

Since my PR will take a little longer until it is finished feel free to do so.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

5 participants