Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

preparing v2 #41

Merged
merged 2 commits into from
Jul 7, 2022
Merged

preparing v2 #41

merged 2 commits into from
Jul 7, 2022

Conversation

sio4
Copy link
Member

@sio4 sio4 commented Jun 17, 2022

I want to start version 2 of envy. (major version change since the important behavior will be changed)

The current behavior of envy is that it automatically loads .env file from the working directory and overwrites all pre-existing environment variables with the values from the .env. However, this behavior is far from the general priority of configuration: the command-line argument is the first priority, followed by environment variables, otherwise using the configuration file as a default.

Also, nowadays Cloud Computing and/or container technology became the standard runtime platform for applications and most of them provide environment variable-based runtime configuration with static virtual machine images or container images. So file-based configuration should be able to be overridden with environment variables.

After this, API clean-up will be followed before releasing v2.

fixes #36

@sio4 sio4 self-assigned this Jun 17, 2022
@sio4 sio4 added enhancement New feature or request breaking change This feature / fix introduces breaking changes labels Jun 17, 2022
@sio4 sio4 added this to the v2 milestone Jun 17, 2022
@sio4 sio4 requested review from paganotoni and a team June 17, 2022 15:14
@sio4 sio4 enabled auto-merge (rebase) June 17, 2022 15:14
Copy link
Member

@paganotoni paganotoni left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me and I like the rationale behind all this. ENV variables addition usually show more purpose than files which could be easy to forget.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
breaking change This feature / fix introduces breaking changes enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

envy overrides environment variables
2 participants