Drop command requires user confirmation or -y flag and does not allow arguments. #235
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closed
stanislas-m
approved these changes
Sep 9, 2018
|
Thanks! |
|
This is a REALLY big breaking change. A lot of people script around this, including this package. The I think this needs to be reverted. |
|
I'm against reverting the full change. I think we can at least keep the check for extra arguments: this will prevent behaviors such as the one exposed in the issue. |
stanislas-m
added a commit
that referenced
this pull request
Sep 18, 2018
Drop command shouldn't need a confirmation, but we should help to prevent bad mistakes.
|
For those who script around it, can they not just add the `-y` flag?
…On Tue, Sep 18, 2018 at 4:01 PM Stanislas Michalak ***@***.***> wrote:
I'm against reverting the full change. I think we can at least keep the
check for extra arguments: this will prevent behaviors such as the one
exposed in the issue.
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
<#235 (comment)>, or mute
the thread
<https://github.com/notifications/unsubscribe-auth/AHr2mlYomCvhbwF4Aurzi8AIgQZqkx17ks5ucVErgaJpZM4WWP3o>
.
|
stanislas-m
added a commit
that referenced
this pull request
Sep 20, 2018
mclark4386
pushed a commit
that referenced
this pull request
Sep 28, 2018
… arguments. (#235) * Don't allow args and get user confirmation through a flag or input. * changed long form of confirm flag to "yes". Check for more than 0 args. * Standardize confirmation hint. * Add small fixes
mclark4386
pushed a commit
that referenced
this pull request
Sep 28, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is in relation to issue #220.