Refactor whereID to use a tokenized value #249
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
stanislas-m
commented
Sep 21, 2018
stanislas-m
commented
- This will help to use non-string values as IDs, like in Support binary UUID columns in MySQL #243.
- Allow genericExec to use tokenized queries.
- Refactor dialect file names.
* This will help to use non-string values as IDs, like in #243. * Allow genericExec to use tokenized queries. * Refactor dialect file names.
mclark4386
approved these changes
Sep 27, 2018
mclark4386
pushed a commit
that referenced
this pull request
Oct 21, 2018
* Refactor whereID to use a tokenized value * This will help to use non-string values as IDs, like in #243. * Allow genericExec to use tokenized queries. * Refactor dialect file names. * Fix conflict with named and non-named tokens * Fix typo in genericExec * Translate SQL token for postgres and cockroach
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.