Add option to specify package path for models #347
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
reviewed
Feb 10, 2019
There was a problem hiding this comment.
Found some fixes!
P.S. share your ideas, feedbacks or issues with us at https://github.com/fixmie/feedback (this message will be removed after the beta stage).
|
@stanislas-m any thoughts on this PR? Thanks! |
|
@kevinmcconnell It's on my todo list, I just didn't had the time to review it properly. :) |
|
@stanislas-m no worries, just thought I'd check :) |
stanislas-m
requested changes
Feb 24, 2019
This adds a new `--models-path` option to `soda generate model` that
allows changing where the model will be created. The package name will
be the last folder in the path.
For example:
soda generate model User --models-path models/admin
...would create the model files in `./models/admin`, and make them part
of the `admin` package.
|
@stanislas-m that's updated now, per your feedback. Cheers. |
stanislas-m
approved these changes
Mar 3, 2019
|
Thanks for your patience! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds a new
--models-pathoption tosoda generate modelthat allows changing where the model will be created. The package name will be the last folder in the path.For example:
...would create the model files in
./models/admin, and make them part of theadminpackage.This addresses #16 (which I found after discovering I wanted this feature for myself :) )