Update README #549
Update README #549
Conversation
hachi8833
commented
Dec 26, 2017
hachi8833
commented
- Add new classes
- Add a description for Symbols
- Add JetBrains logo
ghost
assigned 
Codecov Report
@@ Coverage Diff @@
## master #549 +/- ##
=======================================
Coverage 82.68% 82.68%
=======================================
Files 53 53
Lines 7001 7001
=======================================
Hits 5789 5789
Misses 967 967
Partials 245 245Continue to review full report at Codecov.
|
- Add new classes - Add a description for Symbols - Add JetBrains logo
hachi8833
force-pushed
the
update_readme
branch
from
9eb8e14
to
2ed973c
Compare
README.md
Outdated
| - Float: `3.14`, `-273.15` | ||
| - String literal: `"string"`, `'string'`, `:string` | ||
| - Symbol literal: `:email`, `{ tel: '9909-999-999' } | ||
| - Symbol literal is `String` class and just a convenient representation of string literals. |
There was a problem hiding this comment.
I think saying Symbol is a convenient representation for Rubyists will be better, since not everyone who interested in Goby a Rubyist.
| - Literals | ||
| - Numeric literal | ||
| - Integer: `100`, `-299`, `-0` | ||
| - Float: `3.14`, `-273.15` |
There was a problem hiding this comment.
We currently can't parsing negative float like this, we need to wrap them like -(273.15). see #526
README.md
Outdated
| - Integer: `100`, `-299`, `-0` | ||
| - Float: `3.14`, `-273.15` | ||
| - String literal: `"string"`, `'string'`, `:string` | ||
| - Symbol literal: `:email`, `{ tel: '9909-999-999' } |
There was a problem hiding this comment.
I think { tel: '9909-999-999' } is just a key value representation? it doesn't tell if tel a symbol or not. And you missed a '`' quote
README.md
Outdated
| - Numeric literal | ||
| - Integer: `100`, `-299`, `-0` | ||
| - Float: `3.14`, `-273.15` | ||
| - String literal: `"string"`, `'string'`, `:string` |
There was a problem hiding this comment.
I think put :string here might cause confusion?
|
@hachi8833 Can we get this merge first? |
|
Updated the PR. |
README.md
Outdated
| @@ -113,6 +113,16 @@ Perhaps Goby should be far easier for Rubyists to comprehend. You can use Ruby's | |||
| - Flow control | |||
| - `if`, `else`, `elsif` | |||
| - `while` | |||
| - Literals | |||
| - Numeric literal | |||
| - Integer: `100`, `(-299)`, `(-0)` | |||
There was a problem hiding this comment.
@hachi8833 I just found that in current master we don't need to wrap parentheses around negative integer or float anymore (at least in igb). Can you help me confirm this? (when did we fix this?)
There was a problem hiding this comment.
I confirmed that bare negative integer/float works as you pointed out, except to_class.
This will be fixed #557.
