This repository has been archived by the owner on Dec 21, 2017. It is now read-only.
Rubocop #1
Merged
Rubocop #1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| # Offense count: 8 | ||
| # Configuration parameters: AllowURI, URISchemes. | ||
| Metrics/LineLength: | ||
| Max: 90 |
There was a problem hiding this comment.
Because I'm a coward.
|
❤️ Rubocop. Could we squish the commits? Otherwise good to |
petehamilton
force-pushed
the
rubocop
branch
5 times, most recently
from
3bd6ac9
to
1bfb0b4
Compare
petehamilton
force-pushed
the
rubocop
branch
from
1bfb0b4
to
42e28a6
Compare
petehamilton
added a commit
that referenced
this pull request
Sep 29, 2014
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@isaacseymour Pretty
beefyfragmented PR which makes us Rubocop compliant (within reason).Look ok?