Encode href params before substituting them into the url

[petehamilton]

@greysteil This fixes https://exceptions.gocardless.com/production/gocardless-live/group/5303/

Review?

Next steps:

1. Bump Atum
2. Update Atum dependency in GCER

[greysteil]

👍

[jackfranklin]

Not saying you should write this differently (in fact, you totally should not), but purely for a "oh this is cool, out of interest", you could write this like so:

params.map!(&URI.method(:escape))

Was curious to see if it would work and apparently it does. Yay Ruby.

[petehamilton]

Cool, didn't think the & map syntax worked/worked nicely for that kind of
call! TIL...

On Thursday, 16 October 2014, Jack Franklin notifications@github.com
wrote:

In lib/atum/core/schema/link_schema.rb:

@@ -58,6 +58,8 @@ def construct_path(*params)
"for #{expected_params.count}"
end

•      params.map! { |param| URI.escape(param) }
  

Not saying you should write this differently (in fact, you totally should
not), but purely for a "oh this is cool, out of interest", you could write
this like so:

params.map!(&URI.method(:escape))

Was curious to see if it would work and apparently it does. Yay Ruby.

—
Reply to this email directly or view it on GitHub
https://github.com/gocardless/atum/pull/12/files#r18985588.

[petehamilton]

@jackfranklin For now I'll probably leave it, bit clearer?

[jackfranklin]

Oh yeah, sorry, I think that you should leave it, yours is much clearer!