This repository has been archived by the owner on Dec 21, 2017. It is now read-only.
Add spec for non-JSON errors containing the response body #14
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@petehamilton I've fixed most of the new cops, and upper the AbcSize to 22 from 15, which makes Rubocop happy for now. I don't think the "complex" methods can be decomposed much anyway. |
|
👍 |
petehamilton
added a commit
that referenced
this pull request
Nov 25, 2014
Add spec for non-JSON errors containing the response body
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Turns out the code is already there for handling them correctly. Can we merge this and get it onto master? @petehamilton can you add me to the RubyGems permissions?