This repository has been archived by the owner on Dec 21, 2017. It is now read-only.
Add request to api errors #17
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@english - can you review? |
| def error | ||
| @error ||= | ||
| if response.json? | ||
| response.body['error'] |
There was a problem hiding this comment.
Wondering whether we may as well just use response.body here on the off chance we don't get back what we're expecting, i.e. no error field. I'm not sure whether that's ever going to happen since if an error gets returned not through our error serializer, its also likely not going to be json. What do you think? Might be really handy if it every happens!
There was a problem hiding this comment.
Good shout - let's put the response.body into the "Unknown error" text below.
|
One comment, but looks good otherwise 👍 |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hugely useful when debugging API errors.