Move to github workflows #104
Conversation
ankithads
force-pushed
the
add-github-workflows
branch
4 times, most recently
from
0ba0fbc
to
58e7564
Compare
ankithads
force-pushed
the
add-github-workflows
branch
3 times, most recently
from
7a33dd9
to
ab30213
Compare
ankithads
force-pushed
the
add-github-workflows
branch
2 times, most recently
from
8356722
to
2166a02
Compare
ankithads
force-pushed
the
add-github-workflows
branch
4 times, most recently
from
fadc415
to
f4532c9
Compare
ankithads
force-pushed
the
add-github-workflows
branch
6 times, most recently
from
7a63321
to
68c4b92
Compare
ankithads
force-pushed
the
add-github-workflows
branch
from
68c4b92
to
4c74ed5
Compare
Gemfile
Outdated
| gem 'prometheus_gcstat', git: 'git@github.com:gocardless/prometheus_gcstat_ruby' | ||
|
|
||
| source "https://rubygems.pkg.github.com/gocardless" do | ||
| gem "prometheus_gcstat", "0.1.1" |
There was a problem hiding this comment.
Do we need to get a new release of this gem? Not sure how old this is.
There was a problem hiding this comment.
Nothing got changed in the code after this version https://github.com/gocardless/prometheus_gcstat_ruby/commits/master/ except for github configs
There was a problem hiding this comment.
Fair. Should we allow any 0.1.x version rather than pin the exact version? That will allow for flexibility as versions upgrade.
spec/lib/que/locker_spec.rb
Outdated
| before { allow(locker).to receive(:monotonic_now) { @epoch } } | ||
|
|
||
| before do | ||
| # we need this to avoid flakiness during resetting the cursor |
There was a problem hiding this comment.
Talked IRL, @ankithads to explain in the comment why this is needed
| @@ -4,7 +4,7 @@ | |||
|
|
|||
| RSpec.describe Que::Middleware::QueueCollector do | |||
| subject(:collector) { described_class.new(->(_env) { nil }, options) } | |||
| let(:options) { {} } | |||
| let(:options) { {refresh_interval: 1.second} } | |||
There was a problem hiding this comment.
This is being added because we don't have database cleaner and the state is being persisted across spec runs. Lowering the interval to 1.second forces the state to be refreshed between runs.
@ankithads to change the spec to force a refresh before the flaky spec, and that is idependent of spec intervals. As a follow-up, we'll ensure that database state is cleared between examples (eg. using DatabaseCleaner).
There was a problem hiding this comment.
So the refresh time comes from the pg_stat_user_tables. Database cleaner does not help here.
Gemfile
Outdated
| gem 'prometheus_gcstat', git: 'git@github.com:gocardless/prometheus_gcstat_ruby' | ||
|
|
||
| source "https://rubygems.pkg.github.com/gocardless" do | ||
| gem "prometheus_gcstat", "0.1.1" |
There was a problem hiding this comment.
Fair. Should we allow any 0.1.x version rather than pin the exact version? That will allow for flexibility as versions upgrade.
ankithads
force-pushed
the
add-github-workflows
branch
from
41162e9
to
c79a2f7
Compare
Configuring Github Actions for tests.