Report entity name to SDT function #85
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
shivansh
requested changes
Mar 7, 2019
| @@ -91,33 +91,14 @@ func (T *Token) UintValue() (uint64, error) { | |||
| return strconv.ParseUint(string(T.Lit), 10, 64) | |||
| } | |||
|
|
|||
| var ( | |||
There was a problem hiding this comment.
I'm not sure but are the variables holding compiled regular expressions required to be global ?
There was a problem hiding this comment.
of course it is not required to be global
in the same time it might be compiled once on package init and used everywhere later
| sdtPlaceholders = regexp.MustCompile(`\$(\d+)`) | ||
| sdtReplacement = []byte("X[$1]") | ||
| ) | ||
|
|
There was a problem hiding this comment.
I think a small comment here explaining the functionality of SDTVal() would be helpful in future. Something along the lines of -
// SDTVal converts a handwritten action expression into an equivalent expression
// usable by gocc during runtime.
// For e.g. the expression `<< $0.(int64) + $2.(int64), nil >>` is converted to
// `X[0].(int64) + X[2].(int64), nil`. `X` usually represents a slice of
// attributes in the code generated by gocc.
There was a problem hiding this comment.
there was no such explanation in the original code, so I do did not add it :)
are you sure any explanation is required here? this code is completely self-explaining FMPOV
onokonem
force-pushed
the
report-entity-name
branch
from
c1d3e66
to
5fbf58b
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
$§wil be replaces by the name of the entity on preparing SDT call