Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Paths for quoted keys don't filter correctly #369

Closed
WillAbides opened this issue Apr 24, 2023 · 0 comments · Fixed by #370
Closed

Paths for quoted keys don't filter correctly #369

WillAbides opened this issue Apr 24, 2023 · 0 comments · Fixed by #370

Comments

@WillAbides
Copy link
Contributor

I had some cases where comments from a comment map didn't show up in the marshaled yaml, and I realized these cases all have keys that require quotes.

Here's a test demonstrating this:
https://go.dev/play/p/U7B7jbXcKg4

I traced it down to path filter not matching in these cases. There is a PR incoming.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix quoted comments WillAbides/go-yaml
1 participant
@WillAbides