Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade to Webpack 5 #12105

Draft
wants to merge 2 commits into
base: master
Choose a base branch
from
Draft

Upgrade to Webpack 5 #12105

wants to merge 2 commits into from

Conversation

chadlwilson
Copy link
Member

@chadlwilson chadlwilson commented Oct 14, 2023

Fixes #10852

Still needs a lot of help/work

  • Generating type files for css may not be working properly in type-declarations-for-css-modules.js and seemed to be removing necessary fields? This was working earlier on some version of webpack/plugins but possibly has broken along the way. May need to double check.

  • Jasmine Karma tests don't work correctly

  • Fix compilation warning

    [DEP_WEBPACK_COMPILATION_ASSETS] DeprecationWarning: Compilation.assets will be frozen in future, all modifications are deprecated.
    BREAKING CHANGE: No more changes should happen to Compilation.assets after sealing the Compilation.
        Do changes to assets earlier, e. g. in Compilation.hooks.processAssets.
        Make sure to select an appropriate stage from Compilation.PROCESS_ASSETS_STAGE_*.
    
  • Needs a new approach to address creating/parsing of manifests for (micro-frontend) asset serving from Java

  • Check general dev experience works fine

  • Get the regression tests passing

  • Other sanity checks

@chadlwilson chadlwilson added build-script dependencies javascript Pull requests that update Javascript code help wanted labels Oct 14, 2023
@chadlwilson chadlwilson added this to the Release 23.4.0 milestone Oct 14, 2023
@chadlwilson chadlwilson force-pushed the webpack5 branch 2 times, most recently from 329fad7 to a99408d Compare October 18, 2023 05:27
@chadlwilson chadlwilson force-pushed the webpack5 branch 3 times, most recently from 9b04387 to edfa8e3 Compare October 26, 2023 06:47
@ZhangJin233
Copy link

ZhangJin233 commented Nov 6, 2023

Hello Chadlwilson @chadlwilson,

I've noticed that there is room for improvement in the Gocd program, and I'm eager to contribute by developing automation test cases for it. I've successfully run Gocd on my Mac environment, but I'm uncertain about the specific test cases that would be most beneficial. Could you please provide some guidance or advice on which test cases would be most valuable for Gocd? Your input would be greatly appreciated.

@chadlwilson
Copy link
Member Author

Hi @ZhangJin233 - perhaps you want to start a separate discussion over at https://github.com/gocd/gocd/discussions ?

I've noticed that there is room for improvement in the Gocd program, and I'm eager to contribute by developing automation test cases for it. I've successfully run Gocd on my Mac environment, but I'm uncertain about the specific test cases that would be most beneficial. Could you please provide some guidance or advice on which test cases would be most valuable for Gocd? Your input would be greatly appreciated.

If you haven't seen already (it's not well documented), GoCD has a large suite of functional tests which drive the UI and APIs over at https://github.com/gocd/ruby-functional-tests which you should take a look at. It also is possible to run these locally, although can take a bit of work.

The main GoCD repository mainly only has unit and module integration tests, but safety relies upon the functional regression tests which are written in Ruby + Gauge + siteprism/capybara.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
build-script dependencies help wanted javascript Pull requests that update Javascript code
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Upgrade to Webpack 5
2 participants