Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

restore map; upgrade geoip-lite #28

Merged
merged 2 commits into from
Jul 2, 2018
Merged

restore map; upgrade geoip-lite #28

merged 2 commits into from
Jul 2, 2018

Conversation

jmank88
Copy link
Contributor

@jmank88 jmank88 commented Jul 2, 2018

This PR restores the map, and upgrades the geoip-lite package to get non-null geo results (though still maybe not totally accurate). Fixes #23. Currently deployed on devnet:
screenshot from 2018-07-02 10-23-10

How concerned about accuracy are we? That dot in Texas is a DO droplet in NYC3 and Vancouver is SFO2, so this may not be a reliable method.

@jmank88 jmank88 requested review from treeder and r-gochain July 2, 2018 15:26
@r-gochain
Copy link

LGTM

@jmank88
Copy link
Contributor Author

jmank88 commented Jul 2, 2018

screenshot from 2018-07-02 16-55-53
Updated disclaimer: This does not represent the entire GoChain network - only authorized signer and proxy nodes. Information is real-time and may not be 100% accurate.

@jmank88 jmank88 merged commit 43f0835 into master Jul 2, 2018
@jmank88 jmank88 deleted the map branch July 2, 2018 21:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants