fix: Postgres DB with non-UTC timezone incorrectly parse in timestamptz fields #252
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…Time(t) output in timestamptz fields
Rascal
changed the title
taylorchu
reviewed
Dec 13, 2022
| @@ -25,7 +25,7 @@ func (d postgreSQL) EncodeBool(b bool) string { | |||
| } | |||
|
|
|||
| func (d postgreSQL) EncodeTime(t time.Time) string { | |||
| return MySQL.EncodeTime(t) | |||
| return `'` + t.Format(time.RFC3339Nano) + `'` | |||
There was a problem hiding this comment.
Could you update dialect.go timeFmt instead so that it is available in all dialects?
There was a problem hiding this comment.
I tested this format with the rest of the bases, MySQL (5.6) and MS SQL (2017) cannot parse time in this format. I suggest using the new format for PostgreSQL, leaving the old implementation for MySQL, SQLite and MS SQL.
There was a problem hiding this comment.
@taylorchu As I pointed out in the comment above, other bases understand a very limited number of formats, I suggest making changes only for Postgres methods.
taylorchu
reviewed
Dec 13, 2022
austintaylor
approved these changes
Sep 25, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#251