Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

issue-2304 remove tab index from accordion item content div on front end #2310

Merged
merged 1 commit into from
Mar 18, 2022

Conversation

snovosel
Copy link
Contributor

@snovosel snovosel commented Mar 7, 2022

Description

This PR resolves an issue for keyboard users where the opened accordion would focus on the accordion body in the front end. As the area is not editable, it is unecessary.

Fixes #2304

Screenshots

Types of changes

Bug fix

How has this been tested?

manually

Acceptance criteria

Should not be able to tab focus the accordion body on the front end

Checklist:

  • My code is tested
  • My code follows accessibility standards
  • My code has proper inline documentation
  • I've included any necessary tests
  • I've included developer documentation
  • I've added proper labels to this pull request

@cypress
Copy link

cypress bot commented Mar 7, 2022



Test summary

404 0 2 0


Run details

Project CoBlocks
Status Passed
Commit 0080170
Started Mar 7, 2022 11:15 PM
Ended Mar 7, 2022 11:20 PM
Duration 04:40 💡
OS Linux Ubuntu - 20.04
Browser Multiple

View run in Cypress Dashboard ➡️


This comment has been generated by cypress-bot as a result of this project's GitHub integration settings. You can manage this integration in this project's settings in the Cypress Dashboard

@godaddy-wordpress-bot
Copy link
Contributor

Performance Test Results:

index master issue-2304 change %
focus 133.93 106.52 -20.47%
inserterHover 37.9 37.88 -0.05%
inserterOpen 129.28 149.04 15.28%
inserterSearch 74.99 111.71 48.97%
load 23454.4 24235 3.33%
maxFocus 156.83 135.37 -13.68%
maxInserterHover 46.74 52.22 11.72%
maxInserterOpen 508.9 629.78 23.75%
maxInserterSearch 131.19 184.27 40.46%
maxType 84.84 81.24 -4.24%
minFocus 112.56 86.83 -22.86%
minInserterHover 32.79 30.57 -6.77%
minInserterOpen 70.16 75.56 7.7%
minInserterSearch 57.47 51.61 -10.2%
minType 38.86 41.9 7.82%
type 50.27 52.02 3.48%

@AnthonyLedesma AnthonyLedesma merged commit 2642106 into master Mar 18, 2022
@AnthonyLedesma AnthonyLedesma deleted the issue-2304 branch March 18, 2022 17:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Type] Bug Something that is not working as expected
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Accordions - Content section gets keyboard focus unnecessarily
3 participants