Bug fixes #38
Merged
Bug fixes #38
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
EvanHerman
commented
Feb 20, 2019
•
EvanHerman
commented
- Fix: Update help tab iframe URL with www - props @aaroncampbell
…ion === 'refresh'
* update text domain for interested translators on translation.wordpress.org to work on plugin strings. * change text domain to match plugin slug in comments * fixing according to travis ci warnings only the i18n warnings. * more fixes based on travis ci output * fixing other warnings * one more warning * renamed language files to match text domain https://developer.wordpress.org/plugins/internationalization/how-to-internationalize-your-plugin/#loading-text-domain
* Add support for GDPR fields. * Update gruntfile and npm dependencies * Add comment for tos_link * Resolve PHPCS warnings. Update phpcs.ruleset.xml. * Remove test filter * Add xmllint addon to travis build config * Double check for method before calling it. Update checkbox field value to match disply text. * Update gem-form-fields test to asset invalid_field_type returns empty. * Readd vendor dir to PHPCS exclusion * Add test for tos_link * Add test for tracking_option * Remove chrome from travis addons * Remove print * Add spacing for phpcs warnings * Add required checkboxes to error checking
…tion updates and updated i18n comments
* Start to build out GEM gutenberg block * Save block output with proper shortcode * Add .babelrbs and webpack.config.js to .distignore * Resolve PHPCS warnings * Dynamically generate the GEM form in the GEM block * Bump tested up to version to 5.0 * Fix PHPCS spacing * Dynamic gem block * Update dynamic blocks * Add GEM block screenshots and update readme * Clean up UX during block addition/form selection. Cleanup JS file. * Add docblock to class prop
Added RU for several messages (Thank you for signing up, There was a problem).
* Fix help tab iframe URL for non-US locales * Fix help tab iframe URL for non-US locales
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.