-
Notifications
You must be signed in to change notification settings - Fork 77
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[PFX-350]: Upgrade to Fastify v4 #727
Conversation
const fastifyLogger = logger; | ||
['fatal', 'trace', 'debug', 'error', 'warn', 'info'].map(level => { | ||
if (!logger[level]) { | ||
fastifyLogger[level] = logLevels[level]; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You will want to fallback to the logger's methods, not the console's.
debug
, error
, info
, and warn
are guaranteed (verify code) to be on the logger.
const fallbackMap = {
fatal: 'error',
trace: 'debug'
}
fastifyLogger[level] = logLevels[level]; | |
fastifyLogger[level] = logger[fallbackMap[level]]; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sounds good! Just made that update.
Summary
This PR includes updates to the BYO logger to be compatible with the
pino
logger used by Fastify.Changelog
Test Plan
Tests Passing