Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Updates to default headers #3

Merged
merged 4 commits into from
Oct 9, 2018
Merged

Updates to default headers #3

merged 4 commits into from
Oct 9, 2018

Conversation

salilagrawal
Copy link
Collaborator

Removing default headers for Content-Type and Accept, as it's not necessary to always use application/json as the type. Also added a condition to read plain text response.

@sagrawal-godaddy
[minor] removing default headers for Content-Type and Accept, as its …
8d4666d 
…not necessary to always use application/json as the type. Also added a condition to read plain text response.
@coveralls
Copy link

coveralls commented Oct 9, 2018 •
edited
Loading

Pull Request Test Coverage Report for Build 29

  • 3 of 3 (100.0%) changed or added relevant lines in 1 file are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 100.0%
Totals Coverage Status
Change from base Build 17: 0.0%
Covered Lines: 153
Relevant Lines: 153
💛 - Coveralls

@kinetifex kinetifex merged commit 7ae8432 into master Oct 9, 2018
@kinetifex kinetifex deleted the header-fix branch October 9, 2018 20:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@salilagrawal @coveralls @kinetifex @sagrawal-godaddy