Remove upward traversal logic for config discovery #479
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jsimmons1-godaddy
approved these changes
Mar 29, 2023
rbailey-godaddy
requested changes
Mar 30, 2023
Co-authored-by: Scott Bailey <72747501+rbailey-godaddy@users.noreply.github.com>
rbailey-godaddy
approved these changes
Mar 30, 2023
| files on the command line. Each file is located and processed in order. When | ||
| conflicting directives are provided in different files, the value in the last | ||
| files on the command line. Paths specified using --config are interpreted | ||
| relative to the current working directory.Each file is located and processed in order. |
There was a problem hiding this comment.
Suggested change
| relative to the current working directory.Each file is located and processed in order. | |
| relative to the current working directory. Each file is located and processed in order. |
emayuri-godaddy
approved these changes
Mar 30, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
To help us get this pull request reviewed and merged quickly, please be sure to include the following items:
This PR removes the upward traversal logic for configuration discovery in Tartufo. Tartufo will no longer look for configuration files in unspecified parent directories.
PR Type
What kind of change does this PR introduce?
Backward Compatibility
Is this change backward compatible with the most recently released version? Does it introduce changes which might change the user experience in any way? Does it alter the API in any way?
This is a breaking change for users who were relying on upward traversal for configuration discovery
Issue Linking
Fixes #475