-
Notifications
You must be signed in to change notification settings - Fork 73
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
updating docs to run current version of tartufo #71
Conversation
Codecov Report
@@ Coverage Diff @@
## master #71 +/- ##
=======================================
Coverage 94.03% 94.03%
=======================================
Files 6 6
Lines 436 436
Branches 86 86
=======================================
Hits 410 410
Misses 18 18
Partials 8 8 Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Overall, I like the updates to the doc. I think it's becoming much more useful. Just a few changes, mostly around the talk of poetry
. 👍
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looking much better. Just a few more fixes and it'll be great!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just a few more things. I really want to be sure we get the docs "right" to be as helpful and educational as possible to our users. Apologies if I'm being a bit pedantic here.
Also, I would encourage testing all these doc changes locally with tox -e docs
and then opening up docs/build/html/index.html
, to make sure things are looking right.
mv pyproject.toml pyproject.toml_bak | ||
mv pyproject.toml_new pyproject.toml | ||
# one final run to make sure your signatures are all set | ||
poetry run tartufo ${gitrepo} --regex --no-cleanup |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think this underscores the need for a new command like tartufo creation-exclusion-list
once #78 is done and merged. 😄
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
yeah, that would be pretty sweet!
No description provided.