Skip to content
This repository has been archived by the owner on Mar 13, 2023. It is now read-only.

Keep grandchild menu flyouts inside the viewable area #40

Closed
frankiejarrett opened this issue Jul 28, 2016 · 2 comments
Closed

Keep grandchild menu flyouts inside the viewable area #40

frankiejarrett opened this issue Jul 28, 2016 · 2 comments
Assignees
Labels

Comments

@frankiejarrett
Copy link
Contributor

If you have a really long Primary Menu with the last item containing children and grandchildren, it's possible for the grandchild flyout menu to be cutoff and overflow outside of the viewable area.

We should add logic to navigation.js to ensure the flyout will appear on the opposite side when it's too close to the browser window's edge.

screen shot 2016-07-28 at 3 46 44 pm

@tobeycodes
Copy link
Contributor

When I was developing Ascension I rewrote Navigation.js with jQuery and solved this problem in the child theme only but I have just removed the navigation.js in Ascension since we recently rewrote it in Primer that solved the original problems. It's one less file to manage in the child theme but it means this problem is back in Ascension until we fix it in Primer for all child themes.

We can at least use it as inspiration to solve the problem here
https://github.com/LiftUX/ascension-theme/blob/develop/assets/js/navigation.js

@frankiejarrett
Copy link
Contributor Author

frankiejarrett pushed a commit that referenced this issue Aug 18, 2016
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

No branches or pull requests

3 participants