Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed docker image and sourcified the repo #452

Closed
wants to merge 5 commits into from

Conversation

Cyclic3
Copy link

@Cyclic3 Cyclic3 commented Nov 20, 2018

The docker image was non-functional, and there appeared to be 2 DLLs in the git repo. I found the source of these DLLs and added them as submodules, and tied them into the project as references.

The docker image doesn't work on my machine, and is hardwired to the existing DLLs. I have modified it a bit to work with the new system, as well as fixing the failure to build bug I had before.

I have run docker build . on this repo and got a binary that appears to run fine. I am yet to test it in game.

@Xinayder
Copy link
Collaborator

Sorry for only getting to this now, but are you sure? It worked for me in my Linux machine (in fact I wrote the Dockerfile in it).

@Cyclic3
Copy link
Author

Cyclic3 commented Dec 31, 2018

@RockyTV Here are my logs:

Sending build context to Docker daemon  4.112MB
Step 1/10 : FROM mono:latest
 ---> 43b7ab8e1f34
Step 2/10 : COPY ./Common /build/Common
 ---> 7653392b9274
Step 3/10 : COPY ./Server /build/Server
 ---> fbdb361fb8f7
Step 4/10 : COPY ./SettingsParser.dll /build/
 ---> 163a85b6b938
Step 5/10 : COPY ./MessageWriter2 /build/
COPY failed: stat /var/lib/docker/tmp/docker-builder029342981/MessageWriter2: no such file or directory

I can fix this by adding a .dll to the end of the first argument of the copy command.

However, this merge also removes the dlls from the repo and replaces them with submodules, which allows the repo to be built fully from source, as well as easing updates of dependencies.

Please feel free to cherry-pick from my commit if the second change is unwanted!

@Cyclic3
Copy link
Author

Cyclic3 commented Dec 31, 2018

I would also like to add that I have used this patched version on my own kuberentes cluster, and it has worked like a charm

@Xinayder
Copy link
Collaborator

I have fixed the Dockerfile. Could you give it a try?

Sorry for taking too long to look at it, turns out there was a typo in the MessageWriter2.dll file, so it wasn't copied to the build directory. I've also included the new UDPMeshLib.dll file that was added in v0.3.0.0.

We don't need to retrieve these DLLs from source because they are already provided in the repository.

@Xinayder Xinayder closed this Apr 13, 2019
@Xinayder Xinayder mentioned this pull request Apr 13, 2019
@Cyclic3
Copy link
Author

Cyclic3 commented Apr 15, 2019

@RockyTV Personally I try to keep as few binaries in my source tree as possible, but I recognise that is more of a personal preference than an objective good. If we are keeping open source binaries in the tree, would it be worth maybe adding a link to them in the readme for interested users?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants