Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ch05 - editor comments #7

Merged
merged 9 commits into from
Jul 5, 2024
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion chapter05/dags/02_branch_function.py
Original file line number Diff line number Diff line change
Expand Up @@ -27,7 +27,7 @@ def _fetch_sales_new(**context):


def _clean_sales(**context):
if context["execution_date"] < pendulum.today("UTC").add(days=-1):
if context["data_interval_start"] < ERP_CHANGE_DATE:
_clean_sales_old(**context)
else:
_clean_sales_new(**context)
Expand Down
2 changes: 1 addition & 1 deletion chapter05/dags/05_condition_function.py
Original file line number Diff line number Diff line change
Expand Up @@ -13,7 +13,7 @@


def _pick_erp_system(**context):
if context["data_interval_start"] < pendulum.today("UTC").add(days=-1):
if context["data_interval_start"] < ERP_CHANGE_DATE:
return "fetch_sales_old"
else:
return "fetch_sales_new"
Expand Down
2 changes: 1 addition & 1 deletion chapter05/dags/13_dag_decorator.py
Original file line number Diff line number Diff line change
Expand Up @@ -14,7 +14,7 @@
)
def taskflow_api_decorator():

@task #C
@task
def train_model():
model_id = str(uuid.uuid4())
return model_id
Expand Down
305 changes: 0 additions & 305 deletions chapter05/docker-compose.yml

This file was deleted.