Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improves diagnostic information for 'Any' type #101

Merged

Conversation

jspaezp
Copy link
Contributor

@jspaezp jspaezp commented Jan 8, 2024

Discussed here:
#100

@codecov-commenter
Copy link

codecov-commenter commented Jan 8, 2024

Codecov Report

Attention: 2 lines in your changes are missing coverage. Please review.

Comparison is base (c85de71) 91.12% compared to head (e8c4300) 90.27%.

Files Patch % Lines
src/pydantic_avro/base.py 0.00% 2 Missing ⚠️

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #101      +/-   ##
==========================================
- Coverage   91.12%   90.27%   -0.85%     
==========================================
  Files           2        2              
  Lines         214      216       +2     
==========================================
  Hits          195      195              
- Misses         19       21       +2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@DaanRademaker
Copy link
Collaborator

Thanks for the pull request! I will approve and merge as soon as I can. I se that some the tests in our pipeline are failing. (Failure to install poetry on 3.7 it seems). I will first need to fix this before I can get this pull request through.

@DaanRademaker
Copy link
Collaborator

Thanks for your contribution. Will merge the changes.

@DaanRademaker DaanRademaker merged commit 6a57ae9 into godatadriven:main Jan 9, 2024
15 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants