format_result should have only 1 parameter #1
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It's a little complex to explain the issue....
In my mind, I think the problem is:
For example, if I am using hirb with ripl-rc
Hirb will render some data types to table format.
If it can't, it will invoke
super
and let parent class(module) to do the work.Thus, the calling chain would be:
However, if we pass 2 parameters to format_result, Ripl::Hirb::format_result will raise
ArgumentError
.This will also occurs if we have other format_result hooks before ripl-rc.
The solution might be using a auxiliary method.
I proposed a fix, feel free to improve it.