-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
List structure #1
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi, @godiarksel👋,
Good job so far coming so far with the progress you've made! 💪💪
Highlights
You have done amazing in the following:
- Webpack was used to set up the project.✔️
- It has an array of simple objects containing the required keys and data types.✔️
- It renders the list to the page excellently.✔️
However, there are some issues that you still need to work on to go to the next project but you are almost there!
Required Changes ♻️
Check the comments under the review.
Optional suggestions
Every comment with the [OPTIONAL] prefix is not crucial enough to stop the approval of this PR. However, I strongly recommend you to take them into account as they can make your code better.
Please, remember to tag me in your question so I can receive the notification.
Cheers and Happy coding!👏👏👏
Feel free to leave any questions or comments in the PR thread if something is not 100% clear.
Please, remember to tag me @brytebee in your question so I can receive the notification.
Use @brytebee on slack for faster responses.
Please, do not open a new Pull Request for re-reviews. You should use the same Pull Request submitted for the first review, either valid or invalid unless it is requested otherwise.
As described in the Code reviews limits policy you have a limited number of reviews per project (check the exact number in your Dashboard). If you think that the code review was not fair, you can request a second opinion using this form.
README.md
Outdated
|
||
> Description the project. | ||
> This is a project undertaken in week two of module two to test our abilities to develop a functional application using Webpack. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
- Optional: This is a good description. However, it can be improved by giving a description of the functionalities of the app in this section.
In future projects, consider implementing this. 🚁
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
-
[OPTIONAL] As required by the previous, Please, add a meaningful
Project description
. Remember A project description is a high-level overview of why you're doing a project. The document explains a project's objectives and essential qualities. Is an essential document that provides your audience with a comprehensive overview of the project. Think of it as the elevator pitch that focuses on what and why without delving into how. -
[OPTIONAL] Kindly, it would be nice to add explicit steps for cloning your app, as this will be of help to non-technical users. You can put the steps to clone and run the project in a new Getting Started section under the project's description. This includes
git clone URL
,cd..
, etc. -
The README file It is the first file a person will see when they encounter your project, so it should be fairly brief but detailed. It will make your project stand out from a bunch of others.
src/index.js
Outdated
// const taskSection = document.querySelector('section'); | ||
const taskInput = document.querySelector('input'); | ||
const taskContainer = document.querySelector('.task-container'); | ||
// const clearBtn = document.querySelector('button'); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
- Required: For a professional-looking code base, kindly remove unused and commented out code. This improves code readability and follows the clean code convention.
src/index.js
Outdated
taskContainer.appendChild(tasksEl); | ||
const checkBox = document.querySelectorAll('.checkbox'); | ||
completeTask(checkBox); | ||
addToLocalStorage(task, false, checkBox.length - 1); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
- Required: Awesome job here 👏👏👏
Although you are required to display a static list, you've gone a step further to implement adding user entered items. However, the listindex
is required to begin from 1. Consider removing the- 1
in the snippetaddToLocalStorage(task, false, checkBox.length - 1);
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi @godiarksel,
You did a great job so far 👏🏼 👏🏼
There are some issues that you still need to work on to go to the next project but you are almost there!
To highlight 💪🏻
- No linter errors. ✔️
- GitHub flow was correctly used. ✔️
👍 Good job!
STATUS: CHANGES REQUESTED ♻️
Please Check the comments under the review and make all required changes
Optional suggestions
Every comment with the [OPTIONAL] prefix is not crucial enough to stop the approval of this PR. However, I strongly recommend you to take them into account as they can make your code better.
Cheers and Happy coding!👏👏👏 💻
Feel free to leave any questions or comments in the PR thread if something is not 100% clear.
Please ping me @BenMukebo when you comment so I can receive the notification.
Please, do not open a new Pull Request for re-reviews. You should use the same Pull Request submitted for the first review, either valid or invalid unless it is requested otherwise.
As described in the Code reviews limits policy you have a limited number of reviews per project (check the exact number in your Dashboard). If you think that the code review was not fair, you can request a second opinion using this form.
README.md
Outdated
|
||
> Description the project. | ||
> This is a project undertaken in week two of module two to test our abilities to develop a functional application using Webpack. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
-
[OPTIONAL] As required by the previous, Please, add a meaningful
Project description
. Remember A project description is a high-level overview of why you're doing a project. The document explains a project's objectives and essential qualities. Is an essential document that provides your audience with a comprehensive overview of the project. Think of it as the elevator pitch that focuses on what and why without delving into how. -
[OPTIONAL] Kindly, it would be nice to add explicit steps for cloning your app, as this will be of help to non-technical users. You can put the steps to clone and run the project in a new Getting Started section under the project's description. This includes
git clone URL
,cd..
, etc. -
The README file It is the first file a person will see when they encounter your project, so it should be fairly brief but detailed. It will make your project stand out from a bunch of others.
} | ||
} | ||
|
||
const taskArray = []; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
- As requested by the previous reviewer 👇🏻
Although you are required to display a static list, you've gone a step further to implement adding user entered items. However, the list index is required to begin from 1. Consider removing the - 1 in the snippet addToLocalStorage(task, false, checkBox.length - 1);
-
Make sure to address these requested changes 😄
-
You should have an array of some simple to do tasks (array of objects) with each object containing three keys - description [
string
], completed [bool
], index: [number
]. -
Then write a function that iterates over the tasks array and populates the HTML list item element for each task.
-
The task array is rendered dynamically to the DOM when the page load and don't forget 🤔 as requested by the previous reviewer the tasks should appear in order of the
index
values for each task
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi @godiarksel,
Your project is complete! There is nothing else to say other than... it's time to merge it
Congratulations! 🎉
Highlights
- No linter errors. ✔️
- GitHub flow is followed. ✔️
- Professional README file. ✔️
- PR has a good title and summary. ✔️
Optional suggestions
Every comment with the [OPTIONAL] prefix won't stop the approval of this PR. However, I strongly recommend you to take them into account as they can make your code better. Some of them were simply missed by the previous reviewer and addressing them will really improve your application.
Cheers and Happy coding!👏👏👏
Feel free to leave any questions or comments in the PR thread if something is not 100% clear.
Please, remember to tag me in your question so I can receive the notification.
As described in the Code reviews limits policy you have a limited number of reviews per project (check the exact number in your Dashboard). If you think that the code review was not fair, you can request a second opinion using this form.
Created the HTML structure for the application and configured the tasks to display dynamically. This was achieved by using Javascript. The CSS styles were also applied for this milestone.