Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Call rustfmt directly, as rustup may not be installed. #59

Merged
merged 1 commit into from
Jan 20, 2023

Conversation

jabcross
Copy link
Contributor

@jabcross jabcross commented Jan 7, 2023

No description provided.

@Bromeon
Copy link
Member

Bromeon commented Jan 15, 2023

This no longer selects the stable toolchain, so it might choose a nightly rustfmt depending on the default toolchain.

I guess it's not that big of a deal. I might anyway look for alternatives here since rustfmt is notoriously slow, and we don't need perfect formatting for generated code.

bors r+

bors bot added a commit that referenced this pull request Jan 15, 2023
59: Call rustfmt directly, as rustup may not be installed. r=Bromeon a=jabcross



Co-authored-by: Pedro Ciambra <pedrociambra@gmail.com>
@Bromeon Bromeon added bug c: tooling CI, automation, tools labels Jan 15, 2023
@bors
Copy link
Contributor

bors bot commented Jan 15, 2023

Build failed:

@Bromeon
Copy link
Member

Bromeon commented Jan 15, 2023

Oh, I need to update the bindings header again...

@Bromeon
Copy link
Member

Bromeon commented Jan 20, 2023

bors r+

@bors
Copy link
Contributor

bors bot commented Jan 20, 2023

Build succeeded:

@bors bors bot merged commit 9c5bdfd into godot-rust:master Jan 20, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug c: tooling CI, automation, tools
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants