-
Notifications
You must be signed in to change notification settings - Fork 42
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Updated the FAQ and changed some of the formatting. #33
Conversation
035bbb0
to
c5f0bb1
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you very much, your changes add some extremely valuable insights 👍🏼
I tried to be quite open about my thoughts, so expect lots of comments 🙂
In cases where I added code or text, it can make sense if you use the "Quote comment" function to get the original formatting -- this is especially true for links within this repo, which are sugared by GitHub. Also feel free to copy-paste anything verbatim.
Some general consistency remarks: maybe check the capitalization of a few keywords -- Rust
, Godot
, godot-rust
, GDNative
, GDScript
. At some point in the distant future I might add CI checks for those 😛
@Bromeon Thank you for all the valuable insight. I've gone ahead and incorporated your changes. I appreciate the thorough look into the full FAQ. If you have any additional changes, please feel free to let me know. |
490b7f3
to
58a811a
Compare
@Bromeon Alrighty. I think the most recent push should resolve the last of the changes. Please let me know if there's anything else that needs doing :) |
It also overlaps somewhat with godot-rust/book#24. |
58a811a
to
af92df6
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I agree, this PR is already big enough, we can always add more and refine things in the future 🙂
af92df6
to
19ac1a9
Compare
Added an additional Q/A that I missed that would probably be useful. Added profiling FAQ to close godot-rust#5 Also added a fix to have the logging recipe get added to the summary as it was previously missing.
19ac1a9
to
aa77f87
Compare
Thanks a lot for this huge contribution! Will definitely help a lot of newcomers to navigate 🙂 |
@Bromeon As I mentioned via discord, I went through the issues and extrapolated on cleaned up the FAQ a bit.
Also added a fix to have the logging recipe get added to the summary as it was previously missing.