Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Multiple-threads loading #425

Merged
merged 56 commits into from
Mar 15, 2020
Merged

Conversation

VitaZheltyakov
Copy link
Contributor

@VitaZheltyakov VitaZheltyakov commented Mar 1, 2020

Multiple-threads loading demo.
This demo shows how you can organize background loading using multiple threads.
Сompatible with the latest stable Godot version (currently 3.2).
For more information, see:
http://docs.godotengine.org/en/3.2/tutorials/io/background_loading.html#using-multiple-threads

Bugsquad edit: Supercedes #281

Copy link
Member

@aaronfranke aaronfranke left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In addition to the below, this needs to be moved to the "loading" folder.

@@ -0,0 +1,145 @@
var thread
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@@ -0,0 +1,15 @@
# Multiple-threads loading demo
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I just recently added README files to the other demos. Please reformat the README to be similar to the others. In particular, remove the sections about Godot versions (not useful documentation) and License (not necessary, the repo as a whole already has a license, the only time it's necessary to specify a license is if specific files are under a different one).

# Call after you instance the class to start the thread.
queue.start()

func _process(delta):
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The warnings need to be silenced. delta is unused, so prefix it with an underscore: _delta.

Please be sure to follow the GDScript style guide. In particular, use two lines between functions.

Correcting the code and description
@VitaZheltyakov
Copy link
Contributor Author

@aaronfranke I adjusted the request as you wanted (I hope).

I want to tell you that your behavior is very disgusting.
You want developers to adapt to your needs. I'm not a telepath. I can 't know what you want to see in the readme.
If you really wanted to help, you would have accepted the request and made the changes yourself.

@aaronfranke
Copy link
Member

There is now a "loading" folder for loading demos. This needs to be moved there.

@VitaZheltyakov
Copy link
Contributor Author

@aaronfranke I made a change.
As I understand it , you are guided by some rules. Where can I find these rules?
You should have given me a link to them right away. Since I spend a lot of time trying to guess your queries.

@aaronfranke
Copy link
Member

aaronfranke commented Mar 14, 2020

The rules are:

  • The demo should work. This includes no errors or warnings.

  • Follow the official style guides, such as the GDScript style guide, which I have linked you.

  • Format your demo similar to other demos. This can change over time, especially recently. For years the demo projects had no maintainer, I was given write access a bit over a month ago and I've been working on improving it in my spare time between college classes. Please understand that we don't currently have a formal guide for this, but there are discussions here and here and here, and mostly you should just look at the other demos for examples.

Also, please understand that once a demo is in this repo, the Godot team has a responsibility to maintain it. We want to make the demos as good as possible the first time they're added rather than accepting code and changing it later.

TL;DR: Make it work, follow the style guides, sorry that we don't have guides for everything, I'm a new and unpaid maintainer working on improving this situation in my spare time.

@VitaZheltyakov
Copy link
Contributor Author

@aaronfranke Your actions only interfere with development.
I and other developers have to guess what you want from us. This is offensive.
If you want to help, write a list of rules and approve it. And then encourage the enforcement of these rules.

@aaronfranke
Copy link
Member

Please read the code of conduct, in particular:

Politeness is expected at all times. Be kind and courteous.
Always assume positive intent from others.

I will write a comprehensive list of rules eventually, but we don't have such a thing right now. In the meantime, I've provided you with what I can.

@VitaZheltyakov
Copy link
Contributor Author

I understand what you want from me (I hope).

@aaronfranke You create such negative situations yourself.
You force developers to look for rules for writing readmis; to guess your wishes.
If you had written at once that it was a demonstration, this situation would not have happened . You wrote "this". What does "this" mean ?

Copy link
Member

@aaronfranke aaronfranke left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. I will squash-and-merge this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants