-
-
Notifications
You must be signed in to change notification settings - Fork 1.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Multiple-threads loading #425
Conversation
Add demo
Correct README
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
In addition to the below, this needs to be moved to the "loading" folder.
@@ -0,0 +1,145 @@ | |||
var thread |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I updated the file here, so you can redownload it from the docs: https://docs.godotengine.org/en/latest/tutorials/io/background_loading.html#using-multiple-threads
@@ -0,0 +1,15 @@ | |||
# Multiple-threads loading demo |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I just recently added README files to the other demos. Please reformat the README to be similar to the others. In particular, remove the sections about Godot versions (not useful documentation) and License (not necessary, the repo as a whole already has a license, the only time it's necessary to specify a license is if specific files are under a different one).
# Call after you instance the class to start the thread. | ||
queue.start() | ||
|
||
func _process(delta): |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The warnings need to be silenced. delta
is unused, so prefix it with an underscore: _delta
.
Please be sure to follow the GDScript style guide. In particular, use two lines between functions.
Correcting the code and description
@aaronfranke I adjusted the request as you wanted (I hope). I want to tell you that your behavior is very disgusting. |
There is now a "loading" folder for loading demos. This needs to be moved there. |
@aaronfranke I made a change. |
The rules are:
Also, please understand that once a demo is in this repo, the Godot team has a responsibility to maintain it. We want to make the demos as good as possible the first time they're added rather than accepting code and changing it later. TL;DR: Make it work, follow the style guides, sorry that we don't have guides for everything, I'm a new and unpaid maintainer working on improving this situation in my spare time. |
@aaronfranke Your actions only interfere with development. |
Please read the code of conduct, in particular:
I will write a comprehensive list of rules eventually, but we don't have such a thing right now. In the meantime, I've provided you with what I can. |
I understand what you want from me (I hope). @aaronfranke You create such negative situations yourself. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good. I will squash-and-merge this.
Multiple-threads loading demo.
This demo shows how you can organize background loading using multiple threads.
Сompatible with the latest stable Godot version (currently 3.2).
For more information, see:
http://docs.godotengine.org/en/3.2/tutorials/io/background_loading.html#using-multiple-threads
Bugsquad edit: Supercedes #281