Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve Dodge the Creeps demo #533

Merged
merged 1 commit into from Oct 8, 2020
Merged

Improve Dodge the Creeps demo #533

merged 1 commit into from Oct 8, 2020

Conversation

van800
Copy link
Contributor

@van800 van800 commented Oct 8, 2020

  1. restore net472:
Sdk is referencing Microsoft.NETFramework.ReferenceAssemblies: https://github.com/godotengine/godot/blob/cc3c671f3b636cbfac9fc74095d5bee753e71ed5/modules/mono/editor/Godot.NET.Sdk/Godot.NET.Sdk/Sdk/Sdk.targets#L18-L33

I was mistaken previously because of this one time warning in Rider https://youtrack.jetbrains.com/issue/RIDER-52053

  1. restore RootNamespace, since default one contains spaces.
    Using default one would cause new added script be invalid, at least as I tried in Rider

aaronfranke
aaronfranke approved these changes Oct 8, 2020
View reviewed changes
Copy link
Member

@aaronfranke aaronfranke left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Squashing this would be nice but this looks good.

@van800
Copy link
Contributor Author

van800 commented Oct 8, 2020

Squashed

@aaronfranke aaronfranke merged commit 1a19c5c into godotengine:master Oct 8, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@aaronfranke aaronfranke aaronfranke approved these changes

Assignees
No one assigned
Labels
enhancement topic:dotnet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@van800 @aaronfranke @Calinou