Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove duplicated code in Sync Audio #3150

Merged
merged 1 commit into from Mar 3, 2020
Merged

Remove duplicated code in Sync Audio #3150

merged 1 commit into from Mar 3, 2020

Commits on Feb 6, 2020

  1. Remove duplicated code 

    Not sure I got this right but it seems like duplicate code to me.

Furthermore I'm not sure what we can use this **time** for as $player.play has no timing arguments to compensate for. There is no `$player.playDelayed(time)`.

Shouldn't we use `_physics_process` for better timing?
    @clemens-tolboom
    clemens-tolboom committed Feb 6, 2020
    Copy the full SHA
    2b94466 View commit details
    Browse the repository at this point in the history