-
-
Notifications
You must be signed in to change notification settings - Fork 2.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Improve guide for development with CLion #5743
Conversation
One issue that was raised on the Godot contributors chat is that CLion doesn't seem to expand shell command usage such as The documentation should probably have a warning about this, telling the user to replace To resolve this in the future, I requested the addition of an universal |
Thank you for the swift review and sorry for the many edits you had to make. Bill had a very good suggestion over on the SCons mailing list regarding the I suppose this could make it into Godot's SConstruct file as a default? I'll add a callout regarding |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice to see you around these parts :) Looks good to me.
I'll wait for your amendment before merging. A squash would be appreciated!
Some of the screenshots seem on the larger side, but if you're busy I can run a compressor on them.
Edit:
Bill had a very good suggestion over on the SCons mailing list regarding the -j issue: https://pairlist4.pair.net/pipermail/scons-users/2022-April/008841.html
I suppose this could make it into Godot's SConstruct file as a default? I'll add a callout regarding -j to this PR for the current setup.
I'll see about this. There may be reasons we don't currently do this, but I'm not aware.
Relevant conversation on the Godot contributors chat in
|
Apply suggestions from code review Apply suggestions from code review Apply suggestions from code review Add callout about CLion not expanding shell commands with example.
@mhilbrunner @Calinou Sorry for this taking so long. I've now amended the PR as discussed and squashed the commits. Thank you for your review. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks! Congratulations for your first merged pull request 🎉
Co-authored-by: Hugo Locurcio <hugo.locurcio@hugo.pro>
This improved guide describes how to use the compilation database generated by SCons to work on Godot with CLion. It also describes a setup that allows single click cleaning/building/debugging/profiling of the Godot editor directly from within CLion. As a heavy CLion user, I can confirm that this should be the preferred workflow when using CLion for Godot development.