Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Incorrect display of Russian characters #218

Closed
Purpursarkans opened this issue Feb 2, 2024 · 6 comments
Closed

Incorrect display of Russian characters #218

Purpursarkans opened this issue Feb 2, 2024 · 6 comments

Comments

@Purpursarkans
Copy link

изображение

OS: archlinux
OS lang: ru
godot installed from steam

@bruvzg
Copy link
Member

bruvzg commented Feb 2, 2024

Nothing in the plugin seems to be Unicode aware.

godot::String msg = git_commit_message(commit.get());

Probably should be godot::String msg = godot::String::utf8(git_commit_message(commit.get()));

branch_names.push_back(godot::String(name));

Same here for branch names and probably every single other use of godot::String.

@Purpursarkans
Copy link
Author

Purpursarkans commented Feb 2, 2024

the previous comment has already suggested why this is so, but I want to add 1 more place without Russian characters, because of which it is impossible to index and commit changes (file names in Russian)
изображение

@Calinou Calinou added the bug label Feb 2, 2024
@Calinou
Copy link
Member

Calinou commented Feb 2, 2024

Would #190 help with this?

@bruvzg
Copy link
Member

bruvzg commented Feb 2, 2024

Would #190 help with this?

It seems to be fixing at least some of the strings, not sure if it's all.

@Purpursarkans
Copy link
Author

Purpursarkans commented Feb 2, 2024

change

godot::String msg = git_commit_message(commit.get());

on

godot::String msg = godot::String::utf8(git_commit_message(commit.get()));

it really helped to fix the Russian language in the commit list, but the Russian language still needs fixing in the index and in the version control tab (I highlighted in green the part that started working correctly)
изображение

@Calinou
Copy link
Member

Calinou commented Mar 28, 2024

Thanks for the report! Consolidating in #150.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants