Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make nodes move together with the comment node that encloses them in GraphEdit #3548

Closed
theoway opened this issue Nov 15, 2021 · 0 comments · Fixed by godotengine/godot#54970

Comments

@theoway
Copy link

theoway commented Nov 15, 2021

Describe the project you are working on

Any 2D/3D game/project in which user has to use VisualScript/VisualShaders editor or any editor based on GraphEdit module.

Describe the problem or limitation you are having in your project

Currently, Godot doesn't allow the nodes to be moved with the comment to which they belong. In most of the visual scripting system, this functionality is present. This lack of functionality worsens when a particular comment node has many sub-comment & member nodes. The user has to go through them all be selecting all nodes and then move them around.

Describe the feature / enhancement and how it helps to overcome the problem or limitation

Adding the functionality, whenever a comment node is moved, all the nodes enclosed by it should move with it, will achieve the desired effect. Having a button/or a control that toggles on/off this particular functionality will also give flexibility to users.

Describe how your proposal will work, with code, pseudo-code, mock-ups, and/or diagrams

This Draft PR provides an implementation of the above mentioned feature. The changes have been made to GraphEdit module, so that this feature is available to the editors that use GraphEdit.

demo.mp4

If this enhancement will not be used often, can it be worked around with a few lines of script?

No, the changes have been introduced in the core.

Is there a reason why this should be core and not an add-on in the asset library?

As the changes have been made to GraphEdit, it is not possible to achieve the same effect with a plugin. Signals will have to be added if a plugin is to be made, which again involves changes in core and complication of things.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants