Making nodes enclosed within comment move with the comment node

[theoway]

Link to proposal
WIP 🚧

Feature addition:
This PR adds the feature that binds the movement/positional changes of nodes enclosed with comment node they are enclosed in. Since the changes are made in GraphEdit module, this feature can be used in VisualScript/VisualShader editors and other modules that are built on top of GraphEdit. This will add to user experience as they don't have to select that particular bunch of nodes every time they want to move it.

Features:

• Binding position changes of the enclosed nodes and comment node together.
• Button to toggle on/off this movement feature

Demo

demo.mp4

Bugsquad edit: Closes godotengine/godot-proposals#3548

[Anaxan]

Thoughts from a Visual Script User.

Looks pretty solid. I think it would help to organize and rearrange Visual Scripts.

Is it possible to add a way to identify a comment when zoomed out or looking on the minimap ? Maybe an option to adjust the size of the Comment Title or tint different comment backgrounds different colors. Different background shapes for different comments? Something that stands out from a distance.

Need a build to try out to give better feedback.

[theoway]

@Anaxan As far as changing the appearance of comment nodes for better readability is considered, it is out of scope of this PR, as it is only targeted towards making combined movement of comment nodes and the nodes enclosed within them.
I'll fix the build errors, so that you can test it out :)

[theoway]

@fire Should I add button/control to enable/disable the feature. Else, it is ready to be merged. Waiting for your reply..

[fire]

I don’t see any reasoning to disable the feature.

[theoway]

I don’t see any reasoning to disable the feature.

@fire Neither do I. This PR is ready to be merged then.

[akien-mga]

I agree with the feature proposal, and the code changes seem fairly straightforward 👍

I suggest that maybe @Chaosus would want to give this a quick check as this should be useful for Visual Shaders too.

[Chaosus]

I did such things with comment nodes myself privately, and less elegant than here. I personally like it - it works as expected.

[akien-mga]

Thanks!